Skip to content

Learner1D fails with extremely narrow features #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
basnijholt opened this issue Dec 19, 2018 · 2 comments
Closed

Learner1D fails with extremely narrow features #78

basnijholt opened this issue Dec 19, 2018 · 2 comments
Labels

Comments

@basnijholt
Copy link
Member

(original issue on GitLab)

opened by Bas Nijholt (@basnijholt) at 2018-06-08T01:15:34.930Z

bokeh_plot__1_

Traceback for <Task finished coro=<AsyncRunner._run() done, defined at /gscratch/home/t-banijh/adaptive/adaptive/runner.py:365> exception=KeyError((-0.18000000000275307, -0.18000000000275285),)> (most recent call last):
KeyError: (-0.18000000000275307, -0.18000000000275285)
  File "/gscratch/home/t-banijh/adaptive/adaptive/runner.py", line 321, in status
    return 'failed'
  File "/gscratch/home/t-banijh/adaptive/adaptive/runner.py", line 321, in status
    return 'failed'
  File "/gscratch/home/t-banijh/adaptive/adaptive/runner.py", line 417, in _run
    self.end_time = time.time()
  File "/gscratch/home/t-banijh/adaptive/adaptive/learner/learner1D.py", line 308, in ask
    self.tell(points, itertools.repeat(None))
  File "/gscratch/home/t-banijh/adaptive/adaptive/learner/base_learner.py", line 40, in tell
    self._tell(x, y)
  File "/gscratch/home/t-banijh/adaptive/adaptive/learner/learner1D.py", line 244, in _tell
    self.update_losses(x, real)
  File "/gscratch/home/t-banijh/adaptive/adaptive/learner/learner1D.py", line 159, in update_losses
    loss = self.losses[x_lower, x_upper]

Here the key (-0.18000000000275307, -0.18000000000275285) is spaced only 2e-16 so probably it's reaching machine precision.

@basnijholt basnijholt added the bug label Dec 19, 2018
@basnijholt
Copy link
Member Author

originally posted by Joseph Weston (@jbweston) at 2018-06-08T21:13:55.488Z on GitLab

I don't understand this problem. Why does it raise an exception in this case?

@basnijholt
Copy link
Member Author

originally posted by Bas Nijholt (@basnijholt) at 2018-07-16T18:09:20.173Z on GitLab

Closed by gitlab:!73

jhoofwijk pushed a commit to jhoofwijk/adaptive that referenced this issue Apr 17, 2019
LearnerND scale output values before computing loss

Closes python-adaptive#78

See merge request qt/adaptive!128
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant