handle empty data files when loading, closes #148 #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbweston
requested changes
Jan 23, 2019
There was a problem hiding this comment.
Isn't catching TypeError too general? If someone passes something of the wrong type for fname (e.g. an open file, instead of a file name) this would also raise a TypeError, and that is something that we should not suppress.
Depending on which bit cannot handle empty files we should explicitly check for this condition
basnijholt
force-pushed
the
master
branch
4 times, most recently
from
cb83625 to
7ccb583
Compare
basnijholt
force-pushed
the
empty_data_file
branch
from
fa15c65 to
bb50f94
Compare
|
@jbweston you are right. I fixed it in the appropriate place now. What do you think, should this go to stable or master? |
|
It can go on stable |
jbweston
approved these changes
Jan 30, 2019
basnijholt
force-pushed
the
empty_data_file
branch
from
bb50f94 to
f34efb3
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.