Skip to content

do not force shutdown the executor in the cleanup #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2019

Conversation

basnijholt
Copy link
Member

@basnijholt basnijholt commented Mar 18, 2019

See #156

This prevent the 'OSError: handle is closed' after the runner
is closed in Python 3.7

@basnijholt basnijholt requested a review from akhmerov March 18, 2019 08:25
@basnijholt basnijholt force-pushed the no_force_executor_shutdown branch 2 times, most recently from 986a84a to 79c4269 Compare March 18, 2019 08:27
@basnijholt basnijholt mentioned this pull request Mar 18, 2019
@basnijholt basnijholt force-pushed the no_force_executor_shutdown branch from 79c4269 to 1f6bf6f Compare March 21, 2019 16:30
See #156
This prevent the 'OSError: handle is closed' after the runner
is closed in Python 3.7
@basnijholt basnijholt force-pushed the no_force_executor_shutdown branch from 1f6bf6f to 069964e Compare March 21, 2019 16:36
@basnijholt basnijholt changed the base branch from master to stable-0.7 March 21, 2019 16:36
@basnijholt basnijholt removed the request for review from akhmerov March 21, 2019 16:38
@basnijholt basnijholt merged commit 142bf49 into stable-0.7 Mar 21, 2019
@basnijholt basnijholt deleted the no_force_executor_shutdown branch March 21, 2019 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant