Skip to content

use setup(..., python_requires='>=3.6'), closes #179 #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2019

Conversation

basnijholt
Copy link
Member

As by the suggestion of @Carreau in #179.

@akhmerov
Copy link
Contributor

akhmerov commented Apr 3, 2019

I see the following in py27:

pip install git+https://github.com/python-adaptive/adaptive.git@python_requires                                                                                                      (py27) 
Collecting git+https://github.com/python-adaptive/adaptive.git@python_requires
  Cloning https://github.com/python-adaptive/adaptive.git (to revision python_requires) to /tmp/pip-req-build-uRyzYI
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-req-build-uRyzYI/setup.py", line 19, in <module>
        version, cmdclass = get_version_and_cmdclass('adaptive')
      File "/tmp/pip-req-build-uRyzYI/setup.py", line 11, in get_version_and_cmdclass
        from importlib.util import module_from_spec, spec_from_file_location
    ImportError: No module named util
    
    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-req-build-uRyzYI/

setup.py Outdated
print('adaptive requires Python 3.6 or above.')
sys.exit(1)


Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both are not incompatible. This check is still useful if you have users with pip < 9.0.1 (which is still often the case for Python 2 users).

@basnijholt
Copy link
Member Author

Thanks for checking, I've reverted that change.

@akhmerov
Copy link
Contributor

akhmerov commented Apr 4, 2019

LGTM. pip still fails on 2.7 if installing from source, but that's an unrelated issue which we should fix separately.

@basnijholt basnijholt merged commit e1e3527 into master Apr 4, 2019
@basnijholt basnijholt mentioned this pull request May 6, 2019
@basnijholt basnijholt deleted the python_requires branch May 8, 2019 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants