Skip to content

Authors #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 9, 2019
Merged

Authors #202

merged 2 commits into from
Jul 9, 2019

Conversation

basnijholt
Copy link
Member

@basnijholt basnijholt commented Jun 24, 2019

#201 failed because of a missing author.

This PR allows the author test to fail and separates current maintainers from contributors.

ContinueOnError: true is the same as WarnAndContinue.

@akhmerov
Copy link
Contributor

I believe, authors check should be a part of the linting pipeline. Let's move it there.

@akhmerov akhmerov requested a review from jbweston June 24, 2019 21:33
@basnijholt
Copy link
Member Author

It already is in the linting pipeline.

@akhmerov
Copy link
Contributor

@jbweston what's your opinion specifically on the proposed reorganization of the authors file? (that's the main decision to be made here)

@jbweston
Copy link
Contributor

jbweston commented Jul 2, 2019

@jbweston what's your opinion specifically on the proposed reorganization of the authors file? (that's the main decision to be made here)

I'm fine with the Authors file reorg

Copy link
Contributor

@jbweston jbweston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbweston jbweston merged commit e73df74 into master Jul 9, 2019
@jbweston jbweston deleted the authors branch July 9, 2019 08:28
@basnijholt basnijholt mentioned this pull request Aug 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants