Skip to content

AverageLearner: fix zero mean #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 21, 2021
Merged

AverageLearner: fix zero mean #276

merged 4 commits into from
Aug 21, 2021

Conversation

basnijholt
Copy link
Member

@basnijholt basnijholt commented May 14, 2020

Description

Fixes #275

Checklist

  • Fixed style issues using pre-commit run --all (first install using pip install pre-commit)
  • pytest passed

Type of change

Check relevant option(s).

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@basnijholt basnijholt changed the title WIP: split up aloss and rloss WIP: AverageLearner, fix zero mean May 14, 2020
@basnijholt basnijholt changed the title WIP: AverageLearner, fix zero mean WIP: AverageLearner: fix zero mean May 14, 2020
@basnijholt basnijholt changed the title WIP: AverageLearner: fix zero mean AverageLearner: fix zero mean May 14, 2020
@basnijholt basnijholt enabled auto-merge August 21, 2021 10:13
@basnijholt
Copy link
Member Author

I have enabled Auto-merge.

@codecov-commenter
Copy link

Codecov Report

Merging #276 (9a3f8b9) into master (4e34aba) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #276      +/-   ##
==========================================
+ Coverage   80.46%   80.56%   +0.10%     
==========================================
  Files          35       35              
  Lines        4653     4662       +9     
  Branches      838      839       +1     
==========================================
+ Hits         3744     3756      +12     
+ Misses        783      782       -1     
+ Partials      126      124       -2     
Impacted Files Coverage Δ
adaptive/learner/average_learner.py 86.31% <100.00%> (+0.60%) ⬆️
adaptive/tests/test_average_learner.py 95.12% <100.00%> (+0.67%) ⬆️
adaptive/learner/learner1D.py 89.74% <0.00%> (+0.28%) ⬆️
adaptive/runner.py 71.73% <0.00%> (+0.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e34aba...9a3f8b9. Read the comment docs.

@basnijholt basnijholt merged commit a72d4a0 into master Aug 21, 2021
@basnijholt basnijholt deleted the bug/zero-mean branch August 21, 2021 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AverageLearner doesn't work with 0 mean
2 participants