Skip to content

bump to Python≥3.7 #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 23, 2021
Merged

bump to Python≥3.7 #312

merged 1 commit into from
Mar 23, 2021

Conversation

basnijholt
Copy link
Member

Description

Let's stick with NEP 29 and drop Python 3.6 support.

Checklist

  • Fixed style issues using pre-commit run --all (first install using pip install pre-commit)
  • pytest passed

Type of change

Check relevant option(s).

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • (Code) style fix or documentation update
  • This change requires a documentation update

@codecov-io
Copy link

Codecov Report

Merging #312 (073b848) into master (2d0444b) will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #312      +/-   ##
==========================================
+ Coverage   80.46%   80.55%   +0.08%     
==========================================
  Files          35       35              
  Lines        4633     4633              
  Branches      834      834              
==========================================
+ Hits         3728     3732       +4     
+ Misses        779      777       -2     
+ Partials      126      124       -2     
Impacted Files Coverage Δ
adaptive/learner/learner1D.py 89.97% <0.00%> (+0.57%) ⬆️
adaptive/runner.py 71.53% <0.00%> (+0.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d0444b...073b848. Read the comment docs.

Copy link
Contributor

@akhmerov akhmerov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I imagine this will need a minor version bump, right?

@basnijholt basnijholt merged commit 1e3d26a into master Mar 23, 2021
@basnijholt basnijholt deleted the python37 branch March 23, 2021 11:04
@basnijholt
Copy link
Member Author

I imagine this will need a minor version bump, right?

Yes, I will do that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants