Skip to content

call self._process_futures on canceled futures when BlockingRunner is done #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 27, 2021

Conversation

basnijholt
Copy link
Member

@basnijholt basnijholt commented May 26, 2021

Description

call self._process_futures on canceled futures when BlockingRunner is done.

thanks @jgukelberger for noticing this

Fixes #319

Checklist

  • Fixed style issues using pre-commit run --all (first install using pip install pre-commit)
  • pytest passed

Type of change

Check relevant option(s).

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • (Code) style fix or documentation update
  • This change requires a documentation update

@basnijholt
Copy link
Member Author

It appears that in our tests, the futures of a BlockingRunner do get canceled as expected. So I added a check to filter out the futures that are done.

@basnijholt basnijholt merged commit 1597e9a into master May 27, 2021
@basnijholt basnijholt deleted the fix/process-futs branch May 27, 2021 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Runners should tell learner about remaining points at end of run
2 participants