Fix NaN issue for Learner1D R -> R^n #340
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a function evaluates over a point where it is not defined, NaN will be returned.
In the case of a function R -> R^n, it caused
_update_scale
to computeself._scale[1] = nan
,which in turns led to the evaluation of the function on all other points to be NaN, causing an
infinite loop, as reported in issue #339.
Using
np.nanmin
andnp.nanmax
in place ofnp.min
andnp.max
seems to solve the issue.Fixes #339
Checklist
pre-commit run --all
(first install usingpip install pre-commit
)pytest
passedType of change
Check relevant option(s).