Skip to content

Remove scipy deprecation warnings #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 1, 2022

Conversation

eendebakpt
Copy link
Contributor

@eendebakpt eendebakpt commented Sep 1, 2022

Description

Remove scipy deprecation in learner2D.py

DeprecationWarning: Delaunay attribute 'vertices' is deprecated in favour of 'simplices' and will be removed in Scipy 1.11.0.

Checklist

  • Fixed style issues using pre-commit run --all (first install using pip install pre-commit)
  • pytest passed (does not work locally)

Type of change

Check relevant option(s).

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • (Code) style fix or documentation update
  • This change requires a documentation update

@basnijholt
Copy link
Member

Thanks a lot!

Do you know whether this will work with "older" versions of scipy?

@basnijholt
Copy link
Member

OK this was deprecated in 2012 (scipy/scipy#377) 😂

We can safely merge.

@basnijholt basnijholt merged commit 8b40bf2 into python-adaptive:master Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants