Skip to content

Typehint SequenceLearner #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 11, 2022
Merged

Typehint SequenceLearner #366

merged 3 commits into from
Oct 11, 2022

Conversation

basnijholt
Copy link
Member

Description

Please include a summary of the change and which (if so) issue is fixed.

Fixes #(ISSUE_NUMBER_HERE)

Checklist

  • Fixed style issues using pre-commit run --all (first install using pip install pre-commit)
  • pytest passed

Type of change

Check relevant option(s).

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • (Code) style fix or documentation update
  • This change requires a documentation update

@basnijholt basnijholt force-pushed the typing-sequence-learner branch from 05b9973 to cc8be65 Compare October 9, 2022 02:07
@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2022

Codecov Report

Merging #366 (03a1765) into master (50fae43) will increase coverage by 0.08%.
The diff coverage is 95.23%.

@@            Coverage Diff             @@
##           master     #366      +/-   ##
==========================================
+ Coverage   80.22%   80.31%   +0.08%     
==========================================
  Files          37       37              
  Lines        5375     5384       +9     
  Branches      979      979              
==========================================
+ Hits         4312     4324      +12     
+ Misses        892      891       -1     
+ Partials      171      169       -2     
Impacted Files Coverage Δ
adaptive/learner/sequence_learner.py 86.72% <95.23%> (+1.14%) ⬆️
adaptive/learner/average_learner1D.py 77.66% <0.00%> (-0.67%) ⬇️
adaptive/runner.py 69.28% <0.00%> (+0.68%) ⬆️
adaptive/learner/learner1D.py 89.62% <0.00%> (+0.74%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@basnijholt basnijholt enabled auto-merge (squash) October 11, 2022 16:00
@basnijholt basnijholt merged commit 9860573 into master Oct 11, 2022
@basnijholt basnijholt deleted the typing-sequence-learner branch October 11, 2022 20:29
basnijholt added a commit that referenced this pull request Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants