Skip to content

Use versioningit to work with pyproject.toml and remove setup.py #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2023
Merged

Use versioningit to work with pyproject.toml and remove setup.py #420

merged 1 commit into from
Apr 30, 2023

Conversation

basnijholt
Copy link
Member

@basnijholt basnijholt commented Apr 30, 2023 •
edited
Loading

Description

It turns out that miniver currently doesn't like our new pyproject.toml setup, because the current version is 0.0.0.

Checklist

  • Fixed style issues using pre-commit run --all (first install using pip install pre-commit)
  • pytest passed

Type of change

Check relevant option(s).

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • (Code) style fix or documentation update
  • This change requires a documentation update

@basnijholt basnijholt changed the title Use versioningit Use versioningit to work with pyproject.toml Apr 30, 2023
@basnijholt basnijholt force-pushed the versioningit branch 3 times, most recently from 86eb475 to 8acd1d1 Compare April 30, 2023 06:36
@basnijholt basnijholt marked this pull request as ready for review April 30, 2023 17:32
@basnijholt basnijholt requested review from akhmerov and jbweston April 30, 2023 17:32
@basnijholt basnijholt force-pushed the versioningit branch 2 times, most recently from 2b4eefb to b561ab3 Compare April 30, 2023 19:31
@basnijholt basnijholt changed the title Use versioningit to work with pyproject.toml Use versioningit to work with pyproject.toml and remove setup.py Apr 30, 2023
akhmerov
akhmerov approved these changes Apr 30, 2023
View reviewed changes
Copy link
Contributor

@akhmerov akhmerov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me.

@basnijholt basnijholt enabled auto-merge (squash) April 30, 2023 19:38
@basnijholt basnijholt merged commit 3fbbfba into main Apr 30, 2023
@basnijholt basnijholt deleted the versioningit branch April 30, 2023 19:50
@python-adaptive python-adaptive deleted a comment from akhmerov Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akhmerov akhmerov Awaiting requested review from akhmerov

@jbweston jbweston Awaiting requested review from jbweston

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@basnijholt @akhmerov