Skip to content

Add Learner2D loss function 'thresholded_loss_factory' #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 7, 2023

Conversation

basnijholt
Copy link
Member

Description

Please include a summary of the change and which (if so) issue is fixed.

Fixes #(ISSUE_NUMBER_HERE)

Checklist

  • Fixed style issues using pre-commit run --all (first install using pip install pre-commit)
  • pytest passed

Type of change

Check relevant option(s).

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • (Code) style fix or documentation update
  • This change requires a documentation update

@aeantipov
Copy link
Contributor

I tested it, worked fine.

@aeantipov
Copy link
Contributor

No, sorry on a second test it failed with an error of wrong dimensionality of the data

@basnijholt basnijholt enabled auto-merge (squash) July 7, 2023 20:35
@basnijholt basnijholt disabled auto-merge July 7, 2023 20:42
@basnijholt basnijholt merged commit 88f0258 into main Jul 7, 2023
@basnijholt basnijholt deleted the thresholded-loss branch July 7, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants