Fix type checker error #378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #378 +/- ##
=======================================
Coverage 95.80% 95.80%
=======================================
Files 26 26
Lines 2121 2121
=======================================
Hits 2032 2032
Misses 89 89
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
LGTM, let's just add a small changelog snippet. |
Pyright expects `typing.Type` to be parameterised and reports that the function's type is unknown.
layday
force-pushed
the
fix-type-error-in-pyright
branch
from
985e22e to
5940921
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pyright expects
typing.Typeto be parameterised and reports that the function's type is unknown.