Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't try to upload coverage if CI is run via workflow dispatch on a fork #385

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

AlexWaygood
Copy link
Contributor

While investigating python/typing_extensions#230 and preparing #384, I tried running cattrs's CI on my fork via workflow-dispatch. This was made a little more complicated by the fact that the "upload coverage to codecov" step always seems to fail when the workflow is run on a fork

@Tinche
Copy link
Member

Tinche commented Jun 13, 2023

Thanks! I want to get rid of codecov long-term but still looking for a good alternative.

@Tinche Tinche merged commit 4ad09bc into python-attrs:main Jun 13, 2023
@AlexWaygood AlexWaygood deleted the workflow-dispatch branch June 13, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants