Skip to content

Is best_match() well defined? #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Julian opened this issue Apr 16, 2013 · 0 comments
Closed

Is best_match() well defined? #91

Julian opened this issue Apr 16, 2013 · 0 comments
Labels
Enhancement Some new desired functionality

Comments

@Julian
Copy link
Member

Julian commented Apr 16, 2013

Given an iterable of errors, can we define a useful best_match function that returns the best match of the given errors (i.e. the error that seems to most reasonably represent the validation failure?)

Rough idea:

  • Weigh how deep path and schema_path go into the instance / schema.
  • Use __lt__ on _Error ( 🎀 ) and return max(errors). Why? Because we can.
@Julian Julian mentioned this issue Sep 22, 2013
@Julian Julian closed this as completed Sep 29, 2013
Julian added a commit that referenced this issue Jun 5, 2015
3481a79 Merge pull request #91 from gelraen/nonanchoredpattern
818553f Update pattern.json
b63c96f Merge pull request #92 from gelraen/escapedref
2f043b0 Update ref.json
1ebe2b4 Add valid instances for escaped ref tests
b117902 Add a test that checks for implicit anchoring
d319afa Merge pull request #90 from bugventure/develop
a2c9de2 Add jsen to the list of validators
6d4adfe Merge pull request #87 from legoktm/protocol-relative
824cb99 Add test case for protocol-relative uri validation

git-subtree-dir: json
git-subtree-split: 3481a793ab6a1042a5973549f735b18f2355fb4e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Some new desired functionality
Projects
None yet
Development

No branches or pull requests

1 participant