Skip to content

validators: Fix dependentSchemas when instance is not an object #850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2021

Conversation

robherring
Copy link
Contributor

Just like 'dependentRequired' and 'dependencies', 'dependentSchemas'
needs to handle instance not being an object.

Signed-off-by: Rob Herring [email protected]

Just like 'dependentRequired' and 'dependencies', 'dependentSchemas'
needs to handle instance not being an object.

Signed-off-by: Rob Herring <[email protected]>
@codecov
Copy link

codecov bot commented Oct 1, 2021

Codecov Report

Merging #850 (12a92ea) into main (e61dcbc) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #850      +/-   ##
==========================================
- Coverage   98.29%   98.23%   -0.07%     
==========================================
  Files          19       19              
  Lines        3111     3113       +2     
  Branches      377      378       +1     
==========================================
  Hits         3058     3058              
- Misses         41       42       +1     
- Partials       12       13       +1     
Impacted Files Coverage Δ
jsonschema/_validators.py 97.69% <0.00%> (-0.76%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e61dcbc...12a92ea. Read the comment docs.

@Julian
Copy link
Member

Julian commented Oct 1, 2021

Thanks, appreciated -- we need a test for this upstream in the test suite for this -- it belongs here: https://github.com/json-schema-org/JSON-Schema-Test-Suite/blob/8891d81074300ebb5e551cbda8796e686e586c90/tests/draft2020-12/dependentSchemas.json but should also go in the 2019-09 file.

Can you submit a PR there in that repo for that which I can then merge in here?

@Julian Julian added the Waiting for Author A PR waiting for author changes or issue waiting on reporter feedback label Oct 6, 2021
@Julian
Copy link
Member

Julian commented Oct 20, 2021

@robherring are you interested in finishing this PR?

@robherring
Copy link
Contributor Author

@robherring are you interested in finishing this PR?

@Julian Sorry, haven't had time to get back to this.

@Julian
Copy link
Member

Julian commented Oct 20, 2021

No problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Waiting for Author A PR waiting for author changes or issue waiting on reporter feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants