Skip to content

Move the package metadata from setup.py to setup.cfg #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 11, 2022

Conversation

KOLANICH
Copy link
Contributor

@KOLANICH KOLANICH commented Sep 8, 2021

Added pyproject.toml
Replaced fetching version from a file with fetching a version from version control system tags.
Also fixed a bug with incorrect content of __all__ in __main__.py

@KOLANICH
Copy link
Contributor Author

@ccordoba12

@ccordoba12 ccordoba12 changed the title Moved the metadata into setup.cfg Moved the package metadata from setup.py to setup.cfg Jan 10, 2022
@ccordoba12
Copy link
Member

Thanks for the reminder @KOLANICH! Please rebase on top of the latest develop and fix the merge conflicts.

@ccordoba12 ccordoba12 added this to the v1.1.0 milestone Jan 10, 2022
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also left a couple of small suggestions for you, then this should be ready.

@KOLANICH KOLANICH force-pushed the setup.cfg branch 2 times, most recently from d23a067 to 119556c Compare May 6, 2022 11:29
@KOLANICH
Copy link
Contributor Author

KOLANICH commented May 6, 2022

Thanks for the suggestions, fixed.

@ccordoba12
Copy link
Member

Thanks for continuing your work on this @KOLANICH. I guess you need this one to be merged before continuing with PR #14, right?

Added `pyproject.toml`
Replaced fetching version from a file with fetching a version from version control system tags.
Also fixed a bug with incorrect content of `__all__` in `__main__.py`
@ccordoba12 ccordoba12 changed the title Moved the package metadata from setup.py to setup.cfg Move the package metadata from setup.py to setup.cfg May 11, 2022
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @KOLANICH for your help with this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants