Skip to content

Where to put structured documentation now? #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
krassowski opened this issue Apr 28, 2021 · 13 comments · Fixed by #51
Closed

Where to put structured documentation now? #24

krassowski opened this issue Apr 28, 2021 · 13 comments · Fixed by #51
Assignees
Milestone

Comments

@krassowski
Copy link
Member

Now removed vscode-client had package.json which included a structured documentation of configuration options. Should we retain this file (possibly in a different place/under a different name)?

@krassowski
Copy link
Member Author

We do not need entire file, and it probably should not be named package.json any longer. The lines that would be useful to keep: https://github.com/palantir/python-language-server/blob/a91a257d2c8687a7931721d387b2ffeb6aa71fc2/vscode-client/package.json#L19-L297

@andfoy
Copy link
Contributor

andfoy commented Apr 29, 2021

I think we should probably have a separate configuration markdown document in the repo

@krassowski
Copy link
Member Author

Markdown is nice because it is human-readable but not nice if you ever decide to make a GUI for pylsp settings. I was thinking about preserving the JSON structure for that reason. Maybe we could auto-generate a markdown file or sphinx docs out of such JSON for readability?

@andfoy
Copy link
Contributor

andfoy commented Apr 29, 2021

I think we could have a sample-configuration.json with the actual server configuration.

Maybe the documentation could be similar to the one we use in https://github.com/spyder-ide/pyls-spyder that describes the keys and sections and which hookspecs use them.

@ccordoba12
Copy link
Member

I agree with @andfoy's suggestion.

rwols pushed a commit to sublimelsp/LSP that referenced this issue May 2, 2021
Palantir is no longer maintaining the project. It has been forked and taken up by a new group.

The final link to the complete options list will need to be updated when the new group determines their chosen documentation path. 
python-lsp/python-lsp-server#24
The existing link should suffice for now since currently, the project is a drop-in replacement.
@raprocks
Copy link

Any progress on this? If anyone is not pursuing this maybe someone can point me in some direction so that i can work on it? also we can possibly keep both a json and a markdown format so that we get the best of both worlds haha.

@krassowski
Copy link
Member Author

I would say let's generate markdown from JSON and keep JSON as the source of truth. Feel free to work on this is you like :)

@raprocks
Copy link

well how do i find all the settings that this lsp provides? any references?

@raprocks
Copy link

Oh thanks will take a look at that

@yen3
Copy link

yen3 commented Jul 9, 2021

Thanks for the patch from #51. It lacks the descriptions and definitions for the 3rd Party Plugins. Where could I find? Thank you for your help.

@krassowski
Copy link
Member Author

That's a good question. The obvious answer is that it's best to check in the repositories of respective third party plugins.

The less obvious possibility would be to ask all plugins to follow the same schema format and auto-generate one documentation file for all of them on CI. That would require the central repository to track the plugins (which is somehow already done by the means of linking to some of them). I don't know if this is manageable though.

@andfoy
Copy link
Contributor

andfoy commented Jul 9, 2021

I think it is more feasible letting each plugin to publish their own configuration options, since we cannot handle all updates and it could be probably get outdated easily.

@andfoy andfoy added this to the v1.1.1 milestone Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants