Skip to content

Considering pointing to python-lsp-isort rather than pyls-isort in the README #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
doolio opened this issue Nov 2, 2023 · 1 comment · Fixed by #483
Closed

Considering pointing to python-lsp-isort rather than pyls-isort in the README #478

doolio opened this issue Nov 2, 2023 · 1 comment · Fixed by #483
Labels
task
Milestone
v1.10.0

Comments

@doolio
Copy link
Contributor

doolio commented Nov 2, 2023 •
edited
Loading

python-lsp-isort follows pylsp's configuration convention.

pylsp.plugins.isort.enabled
pylsp.plugins.isort.profile etc.

vs

pylsp.plugins.pyls_isort.enabled
pylsp.plugins.pyls_isort.profile etc.

I had raised pyls-isort/issue#16 and python-lsp-isort/issue#1 respectively.
@ccordoba12
Copy link
Member

Hey @doolio, thanks for reporting. I agree with this change, so you're welcome to submit a pull request to do it.

doolio added a commit to doolio/python-lsp-server that referenced this issue Nov 7, 2023
@doolio
Point to a different isort plugin in README
7cd6911 
This plugin complies with pylsp's configuration conventions.

Resolves: python-lsp#478
@doolio doolio mentioned this issue Nov 7, 2023
Merged
@ccordoba12 ccordoba12 added this to the v1.9.1 milestone Nov 8, 2023
@ccordoba12 ccordoba12 added the task label Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
task
Projects
None yet
Milestone
v1.10.0
Development

Successfully merging a pull request may close this issue.

Point to a more up to date isort plugin in README doolio/python-lsp-server
2 participants
@ccordoba12 @doolio