-
Notifications
You must be signed in to change notification settings - Fork 213
Update Python base version to 3.7+ #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@ccordoba12, updated Python version to 3.7+ and removed python 3.6 slots on Github actions. |
@ccordoba12 or @krassowski or authors, I see issue in static code analysis checks but I think that's not related to this PR. It says validate JSON schema check failed. I just updated the static.yml to use python 3.7 but not sure what's happening? Thank you |
Only difference is that the static checks now use py 3.7 instead of 3.6. |
@krassowski, could you check what's happening with |
I opened python-jsonschema/jsonschema#889. A workaround for now would be to pass an empty instance of settings schema (weather through standard input or from a file). |
Thanks for your help @krassowski!
What do you mean by this? |
I mean something like: echo "{}" | jsonschema pylsp/config/schema.json because an empty instance (empty settings) are acceptable, so they will pass validation. Alternatively we could pin a 3.x version. Ether should solve the problem on the CI for now. |
Updated jsonschema test as mentioned by @krassowski. Now the tests pass. Thank you |
Co-authored-by: Michał Krassowski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks! I don't know if we want to merge immediately or wait until the EOL of Python 3.6 (23 Dec 2021).
Merging as Python 3.6 reached EOL yesterday. |
Updated Python version to 3.7+ as 3.6 came to end-of-life support. Updated tests
related to #128