Skip to content

Fix null reference for syntax errors due to invalid encodings (Pyflakes) #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pylsp/plugins/pyflakes_lint.py
Original file line number Diff line number Diff line change
@@ -52,6 +52,9 @@ def syntaxError(self, _filename, msg, lineno, offset, text):
# We've seen that lineno and offset can sometimes be None
lineno = lineno or 1
offset = offset or 0
# could be None if the error is due to an invalid encoding
# see e.g. https://github.com/python-lsp/python-lsp-server/issues/429
text = text or ""

err_range = {
"start": {"line": lineno - 1, "character": offset},