Skip to content

Pass a single copy of the document's source around for flake8 #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

krassowski
Copy link
Member

Fixes #438 and slightly improves performance when there are many flake8 diagnostics.

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @krassowski!

@ccordoba12 ccordoba12 added this to the v1.8.1 milestone Sep 10, 2023
@ccordoba12 ccordoba12 added the bug Something isn't working label Sep 10, 2023
@ccordoba12 ccordoba12 changed the title Pass a single copy of source around for flake8 Pass a single copy of the document's source around for flake8 Sep 10, 2023
@ccordoba12 ccordoba12 merged commit 6059aa3 into python-lsp:develop Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flake8 can error out when deleting lines
2 participants