Skip to content

Fix extra end line increment in autopep8 plugin #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 27, 2023

Conversation

remisalmon
Copy link
Contributor

@remisalmon remisalmon commented Dec 27, 2023

This is fixing a bug where the line range end (inclusive) is incremented twice, first line 32 just above resulting in formatting an extra line of text.

Tested with Spyder, before:

Screen.Recording.2023-12-26.at.9.31.50.PM.mp4

After:

Screen.Recording.2023-12-26.at.9.33.01.PM.mp4

Same logic in the black plugin:

@ccordoba12 ccordoba12 added the bug Something isn't working label Dec 27, 2023
@ccordoba12 ccordoba12 added this to the v1.10.0 milestone Dec 27, 2023
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @remisalmon!

@ccordoba12 ccordoba12 merged commit 762853c into python-lsp:develop Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants