Skip to content

Fix progress reporting with autoimport plugin #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 13, 2024
+2 −2
Merged

Fix progress reporting with autoimport plugin #530

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c8be83
fix(autoimport): Fix progress reporting
last-partizan Feb 24, 2024
a95136a
chore: Fix test
last-partizan Feb 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pylsp/plugins/rope_autoimport.py
View file
Original file line number Diff line number Diff line change
@@ -37,7 +37,7 @@ def reload_cache(
config: Config,
workspace: Workspace,
files: Optional[List[Document]] = None,
single_thread: Optional[bool] = False,
single_thread: Optional[bool] = True,
):
if self.is_blocked():
return
2 changes: 1 addition & 1 deletion test/plugins/test_autoimport.py
View file
Original file line number Diff line number Diff line change
@@ -313,7 +313,7 @@ def test_autoimport_code_actions_and_completions_for_notebook_document(
)
assert rope_autoimport_settings.get("completions", {}).get("enabled", False) is True
assert rope_autoimport_settings.get("memory", False) is True
wait_for_condition(lambda: not cache.thread.is_alive())
wait_for_condition(lambda: not cache.is_blocked())

# 1.
quick_fixes = server.code_actions("cell_1_uri", {}, make_context("os", 0, 0, 2))