Skip to content

Drop Python 3.8, add Python 3.11 to CI and run pyupgrade #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 28, 2025

Conversation

krassowski
Copy link
Member

@krassowski krassowski commented May 28, 2025

  • Drop Python 3.8, add Python 3.11 to CI
  • Make use of Python 3.9 syntax by running pyupgrade

Copy link
Contributor

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @krassowski for helping with this! Left a suggestion to fix what seems to be a typo in the requires-python definition update (a 0 instead of a 9) but other than that this looks good 👍

Just in case, what do you think @ccordoba12 ?

Edit: Also updated the PR title and description to reflect that the version being dropped is actually Python 3.8

@dalthviz dalthviz changed the title Drop Python 3.9, add Python 3.11 to CI, run pyupgrade Drop Python 3.8, add Python 3.11 to CI, run pyupgrade May 28, 2025
@ccordoba12 ccordoba12 added this to the v1.13.0 milestone May 28, 2025
@ccordoba12 ccordoba12 changed the title Drop Python 3.8, add Python 3.11 to CI, run pyupgrade Drop Python 3.8, add Python 3.11 to CI and run pyupgrade May 28, 2025
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @krassowski!

@ccordoba12 ccordoba12 merged commit e9776fd into python-lsp:develop May 28, 2025
10 checks passed
@krassowski krassowski deleted the python-3.9 branch May 29, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants