Skip to content

Remove temp file and ignore that kind of files #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 4, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -115,3 +115,4 @@ ENV/

# Special files
.DS_Store
*.temp
13 changes: 0 additions & 13 deletions CHANGELOG.temp

This file was deleted.

11 changes: 4 additions & 7 deletions test/test_language_server.py
Original file line number Diff line number Diff line change
@@ -14,8 +14,7 @@
from pylsp.python_lsp import start_io_lang_server, PythonLSPServer

CALL_TIMEOUT = 10
PY2 = sys.version_info[0] == 2
PY3 = sys.version_info[0] == 3
RUNNING_IN_CI = bool(os.environ.get('CI'))


def start_client(client):
@@ -87,8 +86,7 @@ def test_initialize(client_server): # pylint: disable=redefined-outer-name


@flaky(max_runs=10, min_passes=1)
@pytest.mark.skipif(os.name == 'nt' or (sys.platform.startswith('linux') and PY3),
reason='Skipped on win and fails on linux >=3.6')
@pytest.mark.skipif(not sys.platform.startswith('Linux'), reason='Skipped on win and flaky on mac')
def test_exit_with_parent_process_died(client_exited_server): # pylint: disable=redefined-outer-name
# language server should have already exited before responding
lsp_server, mock_process = client_exited_server.client, client_exited_server.process
@@ -104,8 +102,7 @@ def test_exit_with_parent_process_died(client_exited_server): # pylint: disable
assert not client_exited_server.client_thread.is_alive()


@pytest.mark.skipif(sys.platform.startswith('linux') and PY3,
reason='Fails on linux and py3')
@pytest.mark.skipif(sys.platform.startswith('linux'), reason='Fails on linux')
def test_not_exit_without_check_parent_process_flag(client_server): # pylint: disable=redefined-outer-name
response = client_server._endpoint.request('initialize', {
'processId': 1234,
@@ -115,7 +112,7 @@ def test_not_exit_without_check_parent_process_flag(client_server): # pylint: d
assert 'capabilities' in response


@pytest.mark.skipif(bool(os.environ.get('CI')), reason='This test is hanging on CI')
@pytest.mark.skipif(RUNNING_IN_CI, reason='This test is hanging on CI')
def test_missing_message(client_server): # pylint: disable=redefined-outer-name
with pytest.raises(JsonRpcMethodNotFound):
client_server._endpoint.request('unknown_method').result(timeout=CALL_TIMEOUT)