Skip to content

Unmarshallers and validators refactor #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 18, 2023

Conversation

p1c2u
Copy link
Collaborator

@p1c2u p1c2u commented Feb 12, 2023

unmarshallers and validators split

Fixes #483

@p1c2u p1c2u force-pushed the refactor/unmarshallers-format-validators-refactor-2 branch from f9c4fb8 to 3d4c9f1 Compare February 12, 2023 10:54
@codecov
Copy link

codecov bot commented Feb 12, 2023

Codecov Report

Merging #508 (9a57fd6) into master (d22aaf9) will decrease coverage by 2.82%.
The diff coverage is 87.12%.

@@            Coverage Diff             @@
##           master     #508      +/-   ##
==========================================
- Coverage   92.00%   89.19%   -2.82%     
==========================================
  Files         105      124      +19     
  Lines        2991     3564     +573     
  Branches      266      314      +48     
==========================================
+ Hits         2752     3179     +427     
- Misses        192      329     +137     
- Partials       47       56       +9     
Impacted Files Coverage Δ
openapi_core/unmarshalling/schemas/util.py 72.22% <ø> (-14.88%) ⬇️
openapi_core/validation/exceptions.py 83.33% <ø> (-4.17%) ⬇️
openapi_core/validation/processors.py 0.00% <0.00%> (-81.09%) ⬇️
openapi_core/validation/request/__init__.py 100.00% <ø> (ø)
openapi_core/validation/request/datatypes.py 0.00% <0.00%> (-100.00%) ⬇️
openapi_core/validation/response/__init__.py 100.00% <ø> (ø)
openapi_core/validation/schemas/formatters.py 67.64% <ø> (ø)
openapi_core/unmarshalling/request/proxies.py 71.42% <57.14%> (ø)
openapi_core/validation/response/validators.py 72.34% <57.81%> (-15.05%) ⬇️
openapi_core/validation/request/validators.py 76.13% <62.82%> (-12.61%) ⬇️
... and 55 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@p1c2u p1c2u force-pushed the refactor/unmarshallers-format-validators-refactor-2 branch 8 times, most recently from d793a37 to 1aa5731 Compare February 15, 2023 07:01
@p1c2u p1c2u force-pushed the refactor/unmarshallers-format-validators-refactor-2 branch 15 times, most recently from 6cc9050 to a6d026b Compare February 17, 2023 05:23
@p1c2u p1c2u changed the title Unmarshallers format validators refactor Unmarshallers and validators refactor Feb 17, 2023
@p1c2u p1c2u force-pushed the refactor/unmarshallers-format-validators-refactor-2 branch 2 times, most recently from d4d2293 to 7e8c43d Compare February 17, 2023 09:13
@p1c2u p1c2u force-pushed the refactor/unmarshallers-format-validators-refactor-2 branch 2 times, most recently from 9744370 to d673068 Compare February 18, 2023 07:44
@p1c2u p1c2u force-pushed the refactor/unmarshallers-format-validators-refactor-2 branch from d673068 to d8db7ce Compare February 18, 2023 09:36
@p1c2u p1c2u force-pushed the refactor/unmarshallers-format-validators-refactor-2 branch from c35483f to 9a57fd6 Compare February 18, 2023 13:40
@p1c2u p1c2u merged commit 25bc5f0 into master Feb 18, 2023
@p1c2u p1c2u deleted the refactor/unmarshallers-format-validators-refactor-2 branch February 18, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UnmarshallerError if specifying format with type: [foo, 'null']
1 participant