Get sip.pyi in the Docker build #66
Conversation
Dockerfile
Outdated
| # Install SIP including stubs | ||
| # TODO: Find way to build only stubs. This takes way too long | ||
| WORKDIR /upstream/ | ||
| RUN pip install --no-deps --target build sip==${SIP_VERSION} |
There was a problem hiding this comment.
We might want to make this download style consistent with the other build layers.
I think when I wrote the rest of the Dockerfile, I downloaded directly from PyPI's CDN to avoid the python-pip install, but in hindsight that may have been overkill. I'm not opposed to making every layer just use pip.
There was a problem hiding this comment.
Ok, so now that I look the regular PyQt5 package provides its own .pyi files. Why are we building ourselves? (regardless of how we get the sdist)
There was a problem hiding this comment.
They didn't used to be: #40
We may be able to avoid building at this point
There was a problem hiding this comment.
I vote we don't mix switching away from building into this right now. Maybe? Though I do like consistency. Turns out the .pyi are right in the sdist so I'll switch over to the download/extract/copy structure. We can revisit not-building separately.
There was a problem hiding this comment.
Is the update what you were looking for?
There was a problem hiding this comment.
I'm not familiar enough with the differences between find -name and find -wholename, but assuming you had a reason to go with the latter, lgtm
There was a problem hiding this comment.
Yeah, I knew -name was wrong because I had the parent directory in the path but I ran it anyways and it told me to -wholename. At least the present sdist provides two ABIs so we need to pick one over the other.
|
@BryceBeagle, thanks for all your feedback and help with my work here. |
Get sip.pyi in the Docker build
No description provided.