Skip to content

Ping at regular intervals. #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2018
Merged

Ping at regular intervals. #449

merged 1 commit into from
Aug 20, 2018

Conversation

aaugustin
Copy link
Member

Fix #383.

@aaugustin
Copy link
Member Author

This can't be merged yet because it's missing tests.

@vgoklani
Copy link

Is it possible to control the text being passed in the ping: i.e. ping("keepalive")

@codecov
Copy link

codecov bot commented Aug 20, 2018

Codecov Report

Merging #449 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #449   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          31     31           
  Lines        3429   3514   +85     
  Branches      340    344    +4     
=====================================
+ Hits         3429   3514   +85
Impacted Files Coverage Δ
websockets/client.py 100% <ø> (ø) ⬆️
websockets/server.py 100% <ø> (ø) ⬆️
websockets/test_protocol.py 100% <100%> (ø) ⬆️
websockets/test_client_server.py 100% <100%> (ø) ⬆️
websockets/protocol.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2b9537...bd95eaf. Read the comment docs.

Copy link

@bmoscon bmoscon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. I tested your code with my application and it seems to be working. I can force a ping timeout by unplugging a network cable, and the ping timeout was hit within the ping_timeout

@aaugustin aaugustin merged commit 0197e82 into master Aug 20, 2018
@aaugustin
Copy link
Member Author

Thanks @bmoscon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants