-
-
Notifications
You must be signed in to change notification settings - Fork 540
Ping at regular intervals. #449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This can't be merged yet because it's missing tests. |
Is it possible to control the text being passed in the ping: i.e. ping("keepalive") |
Codecov Report
@@ Coverage Diff @@
## master #449 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 31 31
Lines 3429 3514 +85
Branches 340 344 +4
=====================================
+ Hits 3429 3514 +85
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this. I tested your code with my application and it seems to be working. I can force a ping timeout by unplugging a network cable, and the ping timeout was hit within the ping_timeout
Thanks @bmoscon! |
Fix #383.