Skip to content

The PR is blocked by the issue-number check #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
serhiy-storchaka opened this issue Apr 7, 2019 · 3 comments · Fixed by python/bedevere#163
Closed

The PR is blocked by the issue-number check #321

serhiy-storchaka opened this issue Apr 7, 2019 · 3 comments · Fixed by python/bedevere#163
Labels
bot

Comments

@serhiy-storchaka
Copy link
Member

The bedevere bot hanged on the issue-number check and blocks merging python/cpython#12712.
@tirkarthi
Copy link
Member

There are some errors logged at #258 (comment) for bedevere . Almost all PRs to master and backport PRs to maintenance branches today have this check having no return response.

miss-islington issue also has a recent error : #257 (comment)

@tirkarthi tirkarthi mentioned this issue Apr 7, 2019
Merged
@Mariatta Mariatta mentioned this issue Apr 8, 2019
Merged
Mariatta added a commit to python/bedevere that referenced this issue Apr 8, 2019
@Mariatta
Don't pass maintainer_can_modify when patching the PR. (#163)
ebd40d7 
We used to need to pass the `maintainer_can_modify` flag, but now we're getting error message `422 Validation Failed for 'maintainer_can_modify'` when patching the PR. (to append the bpo link)

Removing the `maintainer_can_modify` flag fixes the problem, I tested in command line.
Hopefully this quick fix can unblock people.

Perhaps something changed from GitHub side, but I'm not seeing anything obvious in [their changelog](https://github.blog/changelog/).

Closes #162
Closes python/core-workflow#321
@serhiy-storchaka
Copy link
Member Author

Thanks @Mariatta!

@mariatta-bot
Copy link

Mariatta was mentioned, but she's out of open source from March 18th to May 9th, 2019 . Be aware she might not get to this until after PyCon US.
(I'm a bot)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bot
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't pass maintainer_can_modify when patching the PR. Mariatta/bedevere
3 participants
@serhiy-storchaka @tirkarthi @mariatta-bot