-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
C API documentation index is laid out incorrectly #105196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I would just fix the indentation on the last two. Then, I would check to make sure the link targets are unchanged so that external links into our docs aren't broken. |
Hey, I'm new here, would love to contribute to Python! It's not much of a fix, but can I work on this? If so, which file is this? |
Hi, I made the indentation changes in these two files Doc/build/html/contents.html, Doc/build/html/c-api/concrete.html respectively but these files are untracked so when I am trying to commit the commit is becoming too large. |
@roy9495, were you assigned to this? |
@safwansamsudeen No, I was not assigned. Sorry, I should have asked first. |
We don’t assign issues to contributors. The way it goes is that if you want to work on an issue you leave a comment about that, and if there is such a comment by someone else, and it’s a fairly recent comment, you let them work on it. If it’s an older comment you should ask them if they are still working on it, and if they don’t reply within a reasonable amount of time you can leave a comment to indicate that you are working on it. So basically, we communicate our intentions on the issue. |
@safwansamsudeen Are you still working on this? |
@roy9495 I didn't start it. If you're working on it, that's cool! If you're busy, I'll take it up. |
Ahh @roy9495 I'm sorry, I misread the conversation. My first comment on this issue indicated that I wanted to work on this, and I interpreted your comment to be disregarding mine and working on it instead... which is why I asked if you were assigned to it. I now see you were responding to my request of help, ugh. Thanks, and do accept my apologies for my coldness in my second comment! And great work on the PR! |
@safwansamsudeen Thank you, Please don't apologise. |
…ythonGH-105672) (cherry picked from commit d32e8d6) Co-authored-by: TATHAGATA ROY <[email protected]>
…105672) (#105786) gh-105196: Fix indentations of section headings in C API docs (#105672) Co-authored-by: TATHAGATA ROY <[email protected]>
PR and all backports merged, so closing this now. Thanks @roy9495 and @iritkatriel! |
The last two lines in this snippet should be indented further than the line above them, they are more specific.
(Alternatively, they can be removed because they don't add much).
Linked PRs
The text was updated successfully, but these errors were encountered: