Skip to content

Typo in __cplusplus macro #106479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dtrodrigues opened this issue Jul 6, 2023 · 0 comments
Closed

Typo in __cplusplus macro #106479

dtrodrigues opened this issue Jul 6, 2023 · 0 comments
Labels
type-bug An unexpected behavior, bug, or error

Comments

@dtrodrigues
Copy link
Contributor

dtrodrigues commented Jul 6, 2023

There is a typo in _testcppext.cpp

#if _cplusplus >= 201103
// Test nullptr passed as PyObject*
Py_XINCREF(nullptr);
Py_XDECREF(nullptr);
#endif
causing the if to never evaluate as true.

Linked PRs

@dtrodrigues dtrodrigues added the type-bug An unexpected behavior, bug, or error label Jul 6, 2023
benjaminp pushed a commit that referenced this issue Jul 6, 2023
…106493)

closes gh-106479: fix typo in __cplusplus macro (gh-106480)
(cherry picked from commit 67a7988)

Co-authored-by: Dustin Rodrigues <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

No branches or pull requests

1 participant