-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
The pre-commit hooks do not work on macOS #110652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Simply executing these scripts directly would also do: $ head -n1 Tools/patchcheck/*.py
==> Tools/patchcheck/patchcheck.py <==
#!/usr/bin/env python3
==> Tools/patchcheck/reindent.py <==
#! /usr/bin/env python3
==> Tools/patchcheck/untabify.py <==
#! /usr/bin/env python3 |
Yep, see also comments at #109891 (comment). We can't use Let's check if direct execution works on Windows. |
Unfortunately neither approach works on Windows: see #110653 (comment) :// |
Agree to revert. I'd prefer to replace |
Surely there must be existing hooks we can use. If we need CPython specific hooks, we can create a repo for them under the GitHub |
Unfortunately, there is no
python
on macOS; onlypython3
. Can we change these topython3
?Linked PRs
The text was updated successfully, but these errors were encountered: