Skip to content

Error in example of tempfile module #111282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kkarbowiak opened this issue Oct 24, 2023 · 4 comments
Closed

Error in example of tempfile module #111282

kkarbowiak opened this issue Oct 24, 2023 · 4 comments
Labels
3.12 only security fixes 3.13 bugs and security fixes docs Documentation in the Doc dir

Comments

@kkarbowiak
Copy link
Contributor

kkarbowiak commented Oct 24, 2023 •
edited by bedevere-app bot
Loading

Documentation

The third example in Examples section of tempfile module shows creating TemporaryFile with delete_on_close parameter, however the parameter is present only in NamedTemporaryFile class. Also, a colon is missing several lines below.

The Examples in 3.12 version is the same, so both 3.13 and 3.12 versions are affected.

Linked PRs
@kkarbowiak kkarbowiak added the docs Documentation in the Doc dir label Oct 24, 2023
@bedevere-app bedevere-app bot mentioned this issue Oct 24, 2023
Merged
@Eclips4 Eclips4 added 3.12 only security fixes 3.13 bugs and security fixes labels Oct 24, 2023
@DavidCoy77
Copy link

Hello, I'm an undergraduate computer science student and I'm eager to make a first contribution to GitHub. Would you be willing to offer some guidance to help me through this issue? Thanks!

@kkarbowiak
Copy link
Contributor Author

Hello, I'm an undergraduate computer science student and I'm eager to make a first contribution to GitHub. Would you be willing to offer some guidance to help me through this issue? Thanks!

Hello @DavidCoy77. It's cool you are eager to contribute, however there is already a PR with fix for this issue.

@DavidCoy77
Copy link

Oops! Sorry, that's my fault for not noticing.

zware pushed a commit that referenced this issue Oct 31, 2023
@kkarbowiak
gh-111282: Fix NamedTemporaryFile example code (GH-111283)
102685c
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Oct 31, 2023
@kkarbowiak @miss-islington
pythongh-111282: Fix NamedTemporaryFile example code (pythonGH-111283)
d7a2f3a 
(cherry picked from commit 102685c)

Co-authored-by: Krzysiek Karbowiak <[email protected]>
@bedevere-app bedevere-app bot mentioned this issue Oct 31, 2023
Merged
zware pushed a commit that referenced this issue Oct 31, 2023
@miss-islington @kkarbowiak
[3.12] gh-111282: Fix NamedTemporaryFile example code (GH-111283) (GH…
21c8fbf 
…-111579)

(cherry picked from commit 102685c)

Co-authored-by: Krzysiek Karbowiak <[email protected]>
@zware
Copy link
Member

zware commented Oct 31, 2023

Thanks for the report and patch, @kkarbowiak!

@zware zware closed this as completed Oct 31, 2023
FullteaR pushed a commit to FullteaR/cpython that referenced this issue Nov 3, 2023
@kkarbowiak @FullteaR
pythongh-111282: Fix NamedTemporaryFile example code (pythonGH-111283)
b0b2341
aisk pushed a commit to aisk/cpython that referenced this issue Feb 11, 2024
@kkarbowiak @aisk
pythongh-111282: Fix NamedTemporaryFile example code (pythonGH-111283)
57fcaa0
Glyphack pushed a commit to Glyphack/cpython that referenced this issue Sep 2, 2024
@kkarbowiak @Glyphack
pythongh-111282: Fix NamedTemporaryFile example code (pythonGH-111283)
8b55c24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.12 only security fixes 3.13 bugs and security fixes docs Documentation in the Doc dir
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@zware @kkarbowiak @Eclips4 @DavidCoy77