Skip to content

Use explicit constants in stack effects when known. #116468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
markshannon opened this issue Mar 7, 2024 · 1 comment
Closed

Use explicit constants in stack effects when known. #116468

markshannon opened this issue Mar 7, 2024 · 1 comment
Assignees
@markshannon
Labels
3.13 bugs and security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) performance Performance or resource usage

Comments

@markshannon
Copy link
Member

markshannon commented Mar 7, 2024 •
edited by bedevere-app bot
Loading

We use oparg for stack effects even when oparg is a constant for a particular specialization.
For example UNPACK_SEQUENCE_TUPLE is defined as:

inst(UNPACK_SEQUENCE_TWO_TUPLE, (unused/1, seq -- values[oparg]))

resulting in slightly inefficient code. It should be defined as:

inst(UNPACK_SEQUENCE_TWO_TUPLE, (unused/1, seq -- val1, val0))

Linked PRs
@markshannon markshannon added performance Performance or resource usage interpreter-core (Objects, Python, Grammar, and Parser dirs) 3.13 bugs and security fixes labels Mar 7, 2024
@markshannon markshannon self-assigned this Mar 7, 2024
@bedevere-app bedevere-app bot mentioned this issue Mar 7, 2024
Merged
markshannon added a commit that referenced this issue Mar 11, 2024
@markshannon
GH-116468: Use constants instead of oparg in stack effects when `op…
4e5df20 
…arg` is known to be a constant. (GH-116469)
@hugovk
Copy link
Member

hugovk commented Mar 15, 2024

Triage: can this issue be closed?

adorilson pushed a commit to adorilson/cpython that referenced this issue Mar 25, 2024
@markshannon @adorilson
pythonGH-116468: Use constants instead of oparg in stack effects wh…
c736d63 
…en `oparg` is known to be a constant. (pythonGH-116469)
diegorusso pushed a commit to diegorusso/cpython that referenced this issue Apr 17, 2024
@markshannon @diegorusso
pythonGH-116468: Use constants instead of oparg in stack effects wh…
ea2ece0 
…en `oparg` is known to be a constant. (pythonGH-116469)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markshannon markshannon

Labels
3.13 bugs and security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) performance Performance or resource usage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hugovk @markshannon