Skip to content

Make syslog thread-safe in --disable-gil builds #117440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
colesbury opened this issue Apr 2, 2024 · 0 comments
Closed

Make syslog thread-safe in --disable-gil builds #117440

colesbury opened this issue Apr 2, 2024 · 0 comments
Labels
topic-free-threading type-feature A feature request or enhancement

Comments

@colesbury
Copy link
Contributor

colesbury commented Apr 2, 2024

Feature or enhancement

The syslog module has two mutable global variables:

static PyObject *S_ident_o = NULL; // identifier, held by openlog()
static char S_log_open = 0;

We need to protect access to these variables in the --disable-gil builds.

Linked PRs

@colesbury colesbury added type-feature A feature request or enhancement topic-free-threading labels Apr 2, 2024
colesbury added a commit to colesbury/cpython that referenced this issue Apr 2, 2024
Use critical sections to protect access to the syslog module.
colesbury added a commit to colesbury/cpython that referenced this issue Apr 2, 2024
colesbury added a commit that referenced this issue Apr 2, 2024
Use critical sections to protect access to the syslog module.
diegorusso pushed a commit to diegorusso/cpython that referenced this issue Apr 17, 2024
…ython#117441)

Use critical sections to protect access to the syslog module.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic-free-threading type-feature A feature request or enhancement
Projects
None yet
Development

No branches or pull requests

1 participant