Skip to content

Improve links in ast.rst #118100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sobolevn opened this issue Apr 19, 2024 · 2 comments
Closed

Improve links in ast.rst #118100

sobolevn opened this issue Apr 19, 2024 · 2 comments
Assignees
@sobolevn
Labels
docs Documentation in the Doc dir type-bug An unexpected behavior, bug, or error

Comments

@sobolevn
Copy link
Member

sobolevn commented Apr 19, 2024 •
edited by bedevere-app bot
Loading

Bug report

There are two problems:

  1. cpython/Doc/library/ast.rst

    Line 2539 in 15b3555

    `leoAst.py <https://leoeditor.com/appendices.html#leoast-py>`_ unifies the
    but https://leoeditor.com/appendices.html#leoast-py does not exist anymore, correct link is https://leo-editor.github.io/leo-editor/appendices.html#leoast-py
  2. I also propose to remove parso, because it is no longer maintained for the last 4 years, no new syntax since 3.9? is supported: https://github.com/davidhalter/parso/graphs/contributors

Linked PRs
@sobolevn sobolevn added type-bug An unexpected behavior, bug, or error docs Documentation in the Doc dir labels Apr 19, 2024
@sobolevn sobolevn self-assigned this Apr 19, 2024
sobolevn added a commit to sobolevn/cpython that referenced this issue Apr 19, 2024
@sobolevn
pythongh-118100: Improve links in ast.rst
55a3f4a
@bedevere-app bedevere-app bot mentioned this issue Apr 19, 2024
Merged
sobolevn added a commit that referenced this issue Apr 19, 2024
@sobolevn @hugovk
gh-118100: Improve links in ast.rst (#118101)
2aa11cc 
Co-authored-by: Hugo van Kemenade <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Apr 19, 2024
@sobolevn @hugovk @miss-islington
pythongh-118100: Improve links in ast.rst (pythonGH-118101)
bc100d7 
(cherry picked from commit 2aa11cc)

Co-authored-by: Nikita Sobolev <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
@bedevere-app bedevere-app bot mentioned this issue Apr 19, 2024
Merged
sobolevn added a commit that referenced this issue Apr 19, 2024
@miss-islington @sobolevn @hugovk
[3.12] gh-118100: Improve links in ast.rst (GH-118101) (#118110)
ecb8e2b 
gh-118100: Improve links in `ast.rst` (GH-118101)
(cherry picked from commit 2aa11cc)

Co-authored-by: Nikita Sobolev <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
@hugovk
Copy link
Member

hugovk commented Apr 19, 2024

Reminder: what's the next step after merging the PR and backport? :)

@sobolevn
Copy link
Member Author

Reminder: what's the next step after merging the PR and backport? :)

Openning a new issue and a new PR! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sobolevn sobolevn

Labels
docs Documentation in the Doc dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hugovk @sobolevn