Implement vectorcall for BaseException to optimize creation of exception instances #118702
Labels
performance
Performance or resource usage
Comments
vstinner
added a commit
to vstinner/cpython
that referenced
this issue
May 7, 2024
* BaseException_vectorcall() now creates a tuple from 'args' array.
* Creation an exception using BaseException_vectorcall() is now a
single function call, rather than having to call
BaseException_new() and then BaseException_init().
Calling BaseException_init() is inefficient since it overrides
the 'args' attribute.
* _PyErr_SetKeyError() now uses PyObject_CallOneArg() to create the
KeyError instance to use BaseException_vectorcall().
Micro-benchmark on creating a KeyError on accessing a non-existent
dictionary key:
Mean +- std dev: 447 ns +- 31 ns -> 373 ns +- 15 ns: 1.20x faster
vstinner
added a commit
to vstinner/cpython
that referenced
this issue
May 10, 2024
* BaseException_vectorcall() now creates a tuple from 'args' array.
* Creation an exception using BaseException_vectorcall() is now a
single function call, rather than having to call
BaseException_new() and then BaseException_init().
Calling BaseException_init() is inefficient since it overrides
the 'args' attribute.
* _PyErr_SetKeyError() now uses PyObject_CallOneArg() to create the
KeyError instance to use BaseException_vectorcall().
Micro-benchmark on creating a KeyError on accessing a non-existent
dictionary key:
Mean +- std dev: 447 ns +- 31 ns -> 373 ns +- 15 ns: 1.20x faster
vstinner
added a commit
to vstinner/cpython
that referenced
this issue
May 10, 2024
* BaseException_vectorcall() now creates a tuple from 'args' array.
* Creation an exception using BaseException_vectorcall() is now a
single function call, rather than having to call
BaseException_new() and then BaseException_init().
Calling BaseException_init() is inefficient since it overrides
the 'args' attribute.
* _PyErr_SetKeyError() now uses PyObject_CallOneArg() to create the
KeyError instance to use BaseException_vectorcall().
Micro-benchmark on creating a KeyError on accessing a non-existent
dictionary key:
Mean +- std dev: 447 ns +- 31 ns -> 373 ns +- 15 ns: 1.20x faster
vstinner
added a commit
that referenced
this issue
May 10, 2024
* BaseException_vectorcall() now creates a tuple from 'args' array. * Creation an exception using BaseException_vectorcall() is now a single function call, rather than having to call BaseException_new() and then BaseException_init(). Calling BaseException_init() is inefficient since it overrides the 'args' attribute. * _PyErr_SetKeyError() now uses PyObject_CallOneArg() to create the KeyError instance to use BaseException_vectorcall().
estyxx
pushed a commit
to estyxx/cpython
that referenced
this issue
Jul 17, 2024
* BaseException_vectorcall() now creates a tuple from 'args' array. * Creation an exception using BaseException_vectorcall() is now a single function call, rather than having to call BaseException_new() and then BaseException_init(). Calling BaseException_init() is inefficient since it overrides the 'args' attribute. * _PyErr_SetKeyError() now uses PyObject_CallOneArg() to create the KeyError instance to use BaseException_vectorcall().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Currently, creating an instance of an built-in exception uses the old METH_VARARGS calling convention which creates a temporary tuple to pass positional arguments.
I propose to implement vectorcall for BaseException.
Linked PRs
The text was updated successfully, but these errors were encountered: