Skip to content

PyREPL: KeyboardInterrupt does not clear completion menu if it's already visible #119553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lysnikolaou opened this issue May 25, 2024 · 1 comment
Closed

PyREPL: KeyboardInterrupt does not clear completion menu if it's already visible #119553

lysnikolaou opened this issue May 25, 2024 · 1 comment
Assignees
@lysnikolaou
Labels
3.13 bugs and security fixes 3.14 bugs and security fixes topic-repl Related to the interactive shell type-bug An unexpected behavior, bug, or error

Comments

@lysnikolaou
Copy link
Member

lysnikolaou commented May 25, 2024 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

Pressing Ctrl-C (and emitting a KeyboardInterrupt) while the completion menu is visible (after having pressed Tab) does not clear it before the next line.

>>> import itertools
itertools.accumulate(                     itertools.groupby(                        
itertools.batched(                        itertools.islice(                         
itertools.chain(                          itertools.pairwise(                       
itertools.combinations(                   itertools.permutations(                   
itertools.combinations_with_replacement(  itertools.product(                        
itertools.compress(                       itertools.repeat(                         
itertools.count(                          itertools.starmap(                        
itertools.cycle(                          itertools.takewhile(                      
itertools.dropwhile(                      itertools.tee(                            
itertools.filterfalse(                    itertools.zip_longest(                    
>>> itertools.

KeyboardInterrupt
itertools.accumulate(                     itertools.groupby(                        
itertools.batched(                        itertools.islice(                         
itertools.chain(                          itertools.pairwise(                       
itertools.combinations(                   itertools.permutations(                   
itertools.combinations_with_replacement(  itertools.product(                        
itertools.compress(                       itertools.repeat(                         
itertools.count(                          itertools.starmap(                        
itertools.cycle(                          itertools.takewhile(                      
itertools.dropwhile(                      itertools.tee(                            
itertools.filterfalse(                    itertools.zip_longest(                    
>>>

CPython versions tested on:

CPython main branch

Operating systems tested on:

macOS

Linked PRs
@lysnikolaou lysnikolaou added type-bug An unexpected behavior, bug, or error topic-repl Related to the interactive shell labels May 25, 2024
@lysnikolaou lysnikolaou self-assigned this May 25, 2024
@AlexWaygood AlexWaygood changed the title PyREPL: KeyboardInterrupt does not clear comletion menu if it's already visible PyREPL: KeyboardInterrupt does not clear completion menu if it's already visible May 25, 2024
@AlexWaygood AlexWaygood added 3.13 bugs and security fixes 3.14 bugs and security fixes labels May 25, 2024
lysnikolaou added a commit to lysnikolaou/cpython that referenced this issue May 30, 2024
@lysnikolaou
pythongh-119553: Clear reader on Ctrl-C command
dcac548 
Also, do not print extra newline on before KeyboardInterrupt.
@bedevere-app bedevere-app bot mentioned this issue May 30, 2024
Merged
ambv pushed a commit that referenced this issue Jun 4, 2024
@lysnikolaou
gh-119553: Clear reader on Ctrl-C command (GH-119801)
010ea93
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 4, 2024
@lysnikolaou @miss-islington
pythongh-119553: Clear reader on Ctrl-C command (pythonGH-119801)
5c50dc7 
(cherry picked from commit 010ea93)

Co-authored-by: Lysandros Nikolaou <[email protected]>
@bedevere-app bedevere-app bot mentioned this issue Jun 4, 2024
Merged
lysnikolaou added a commit that referenced this issue Jun 4, 2024
@miss-islington @lysnikolaou @ambv
[3.13] gh-119553: Clear reader on Ctrl-C command (GH-119801) (#120062)
93b95e9 
(cherry picked from commit 010ea93)

Co-authored-by: Lysandros Nikolaou <[email protected]>
Co-authored-by: Łukasz Langa <[email protected]>
lysnikolaou added a commit to lysnikolaou/cpython that referenced this issue Jun 4, 2024
@lysnikolaou
pythongh-119553: Fix console when pressing Ctrl-C within a multiline …
c9117af 
…block
@bedevere-app bedevere-app bot mentioned this issue Jun 4, 2024
Merged
lysnikolaou added a commit that referenced this issue Jun 4, 2024
@lysnikolaou
gh-119553: Fix console when pressing Ctrl-C within a multiline block (#…
69b3e8e 
…120075)
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 4, 2024
@lysnikolaou @miss-islington
pythongh-119553: Fix console when pressing Ctrl-C within a multiline …
4b92985 
…block (pythonGH-120075)

(cherry picked from commit 69b3e8e)

Co-authored-by: Lysandros Nikolaou <[email protected]>
@bedevere-app bedevere-app bot mentioned this issue Jun 4, 2024
Merged
lysnikolaou added a commit that referenced this issue Jun 4, 2024
@miss-islington @lysnikolaou
[3.13] gh-119553: Fix console when pressing Ctrl-C within a multiline…
4ac0ccf 
… block (GH-120075) (#120076)

(cherry picked from commit 69b3e8e)

Co-authored-by: Lysandros Nikolaou <[email protected]>
barneygale pushed a commit to barneygale/cpython that referenced this issue Jun 5, 2024
@lysnikolaou @barneygale
pythongh-119553: Clear reader on Ctrl-C command (pythonGH-119801)
456b92f
barneygale pushed a commit to barneygale/cpython that referenced this issue Jun 5, 2024
@lysnikolaou @barneygale
pythongh-119553: Fix console when pressing Ctrl-C within a multiline …
00e04cc 
…block (python#120075)
noahbkim pushed a commit to hudson-trading/cpython that referenced this issue Jul 11, 2024
@lysnikolaou @noahbkim
pythongh-119553: Clear reader on Ctrl-C command (pythonGH-119801)
e1e2d46
noahbkim pushed a commit to hudson-trading/cpython that referenced this issue Jul 11, 2024
@lysnikolaou @noahbkim
pythongh-119553: Fix console when pressing Ctrl-C within a multiline …
86ca483 
…block (python#120075)
estyxx pushed a commit to estyxx/cpython that referenced this issue Jul 17, 2024
@lysnikolaou @estyxx
pythongh-119553: Clear reader on Ctrl-C command (pythonGH-119801)
3d69bd9
estyxx pushed a commit to estyxx/cpython that referenced this issue Jul 17, 2024
@lysnikolaou @estyxx
pythongh-119553: Fix console when pressing Ctrl-C within a multiline …
8daa9a8 
…block (python#120075)
@limwz01
Copy link

limwz01 commented Nov 24, 2024

I just compiled Python 3.13 and I see the fix in the source but somehow it doesn't fix the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lysnikolaou lysnikolaou

Labels
3.13 bugs and security fixes 3.14 bugs and security fixes topic-repl Related to the interactive shell type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lysnikolaou @AlexWaygood @limwz01