Skip to content

test_siginterrupt_off unnecessarily takes 30 minutes in refleak test #120039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
colesbury opened this issue Jun 4, 2024 · 0 comments
Closed

test_siginterrupt_off unnecessarily takes 30 minutes in refleak test #120039

colesbury opened this issue Jun 4, 2024 · 0 comments
Labels
tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@colesbury
Copy link
Contributor

colesbury commented Jun 4, 2024

Bug report

The test_siginterrupt_off test in test_signal expects a timeout and uses support.SHORT_TIMEOUT.

In at least some of the refleak test runners:

  • we bump the overall timeout to 200 minutes:
  • which adjusts support.SHORT_TIMEOUT to five minutes
  • and the test case is run six times

So the test always takes a minimum of 30 minutes.

stdout, stderr = process.communicate(timeout=support.SHORT_TIMEOUT)

@support.requires_resource('walltime')
def test_siginterrupt_off(self):
# If a signal handler is installed and siginterrupt is called with
# a false value for the second argument, when that signal arrives, it
# does not interrupt a syscall that's in progress.
interrupted = self.readpipe_interrupted(False)
self.assertFalse(interrupted)

Linked PRs

@colesbury colesbury added type-bug An unexpected behavior, bug, or error tests Tests in the Lib/test dir labels Jun 4, 2024
colesbury added a commit to colesbury/cpython that referenced this issue Jun 4, 2024
The process is expected to time out. In the refleak builds,
`support.SHORT_TIMEOUT` is often five minutes and we run the tests six
times, so test_signal was taking >30 minutes.
colesbury added a commit that referenced this issue Jun 4, 2024
The process is expected to time out. In the refleak builds,
`support.SHORT_TIMEOUT` is often five minutes and we run the tests six
times, so test_signal was taking >30 minutes.
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 4, 2024
…thonGH-120047)

The process is expected to time out. In the refleak builds,
`support.SHORT_TIMEOUT` is often five minutes and we run the tests six
times, so test_signal was taking >30 minutes.
(cherry picked from commit d419d46)

Co-authored-by: Sam Gross <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 4, 2024
…thonGH-120047)

The process is expected to time out. In the refleak builds,
`support.SHORT_TIMEOUT` is often five minutes and we run the tests six
times, so test_signal was taking >30 minutes.
(cherry picked from commit d419d46)

Co-authored-by: Sam Gross <[email protected]>
colesbury added a commit that referenced this issue Jun 4, 2024
…H-120047) (#120061)

The process is expected to time out. In the refleak builds,
`support.SHORT_TIMEOUT` is often five minutes and we run the tests six
times, so test_signal was taking >30 minutes.
(cherry picked from commit d419d46)

Co-authored-by: Sam Gross <[email protected]>
colesbury added a commit that referenced this issue Jun 4, 2024
…H-120047) (#120060)

The process is expected to time out. In the refleak builds,
`support.SHORT_TIMEOUT` is often five minutes and we run the tests six
times, so test_signal was taking >30 minutes.
(cherry picked from commit d419d46)

Co-authored-by: Sam Gross <[email protected]>
barneygale pushed a commit to barneygale/cpython that referenced this issue Jun 5, 2024
…thon#120047)

The process is expected to time out. In the refleak builds,
`support.SHORT_TIMEOUT` is often five minutes and we run the tests six
times, so test_signal was taking >30 minutes.
noahbkim pushed a commit to hudson-trading/cpython that referenced this issue Jul 11, 2024
…thon#120047)

The process is expected to time out. In the refleak builds,
`support.SHORT_TIMEOUT` is often five minutes and we run the tests six
times, so test_signal was taking >30 minutes.
estyxx pushed a commit to estyxx/cpython that referenced this issue Jul 17, 2024
…thon#120047)

The process is expected to time out. In the refleak builds,
`support.SHORT_TIMEOUT` is often five minutes and we run the tests six
times, so test_signal was taking >30 minutes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

No branches or pull requests

1 participant