Skip to content

test_audit.test_http is running even if the 'network' resource is not enabled #120373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
itamaro opened this issue Jun 11, 2024 · 0 comments
Closed

test_audit.test_http is running even if the 'network' resource is not enabled #120373

itamaro opened this issue Jun 11, 2024 · 0 comments
Assignees
@itamaro
Labels
tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@itamaro
Copy link
Contributor

itamaro commented Jun 11, 2024 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

Running the test_audit test with no resources enabled in an environment with no Internet access takes ~9 minutes. Most of that time is spent waiting for test_http to timeout on network:

./python -m test test_audit -v
...
test_http (test.test_audit.AuditTest.test_http) ... ('http.client.connect', ' ', 'www.python.org 80')
('http.client.send', ' ', '[cannot send]')
ok
...

CPython versions tested on:

3.13, CPython main branch

Operating systems tested on:

Linux, macOS

Linked PRs
@itamaro itamaro added type-bug An unexpected behavior, bug, or error tests Tests in the Lib/test dir labels Jun 11, 2024
@itamaro itamaro self-assigned this Jun 11, 2024
itamaro added a commit to itamaro/cpython that referenced this issue Jun 11, 2024
@itamaro
pythongh-120373: Mark test_audit.test_http as requiring the network r…
2ca6119 
…esource
@bedevere-app bedevere-app bot mentioned this issue Jun 11, 2024
Merged
facebook-github-bot pushed a commit to facebookincubator/cinder that referenced this issue Jun 19, 2024
@itamaro @facebook-github-bot
Patch test_audit.test_http to require 'network' resource
61181f3 
Summary:
see upstream issue: python/cpython#120373
and upstream PR: python/cpython#120374

Reviewed By: mpage

Differential Revision: D58622163

fbshipit-source-id: 09151285af192347bd9502e97f503e06337ab1cd
carljm pushed a commit that referenced this issue Jun 24, 2024
@itamaro
gh-120373: Mark test_audit.test_http as requiring the network resource (
b0e1c51 
#120374)
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 24, 2024
@itamaro @miss-islington
pythongh-120373: Mark test_audit.test_http as requiring the network r…
d25bba9 
…esource (pythonGH-120374)

(cherry picked from commit b0e1c51)

Co-authored-by: Itamar Oren <[email protected]>
@bedevere-app bedevere-app bot mentioned this issue Jun 24, 2024
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 24, 2024
@itamaro @miss-islington
pythongh-120373: Mark test_audit.test_http as requiring the network r…
090391a 
…esource (pythonGH-120374)

(cherry picked from commit b0e1c51)

Co-authored-by: Itamar Oren <[email protected]>
@bedevere-app bedevere-app bot mentioned this issue Jun 24, 2024
Merged
carljm pushed a commit that referenced this issue Jun 24, 2024
@miss-islington @itamaro
[3.12] gh-120373: Mark test_audit.test_http as requiring the network …
7a874b4 
…resource (GH-120374) (#120949)

gh-120373: Mark test_audit.test_http as requiring the network resource (GH-120374)
(cherry picked from commit b0e1c51)

Co-authored-by: Itamar Oren <[email protected]>
carljm pushed a commit that referenced this issue Jun 24, 2024
@miss-islington @itamaro
[3.13] gh-120373: Mark test_audit.test_http as requiring the network …
502a99a 
…resource (GH-120374) (#120948)

gh-120373: Mark test_audit.test_http as requiring the network resource (GH-120374)
(cherry picked from commit b0e1c51)

Co-authored-by: Itamar Oren <[email protected]>
@carljm carljm closed this as completed Jun 24, 2024
mrahtz pushed a commit to mrahtz/cpython that referenced this issue Jun 30, 2024
@itamaro @mrahtz
pythongh-120373: Mark test_audit.test_http as requiring the network r…
1751bb2 
…esource (python#120374)
noahbkim pushed a commit to hudson-trading/cpython that referenced this issue Jul 11, 2024
@itamaro @noahbkim
pythongh-120373: Mark test_audit.test_http as requiring the network r…
aac2132 
…esource (python#120374)
estyxx pushed a commit to estyxx/cpython that referenced this issue Jul 17, 2024
@itamaro @estyxx
pythongh-120373: Mark test_audit.test_http as requiring the network r…
1278cfc 
…esource (python#120374)
facebook-github-bot pushed a commit to facebookincubator/cinder that referenced this issue Feb 10, 2025
@itamaro @facebook-github-bot
Backport gh-120373: Mark test_audit.test_http as requiring the networ…
a38e9ae 
…k resource

Summary:
upstream issue: python/cpython#120373
upstream PR: python/cpython#120374

Running the test_audit test with no resources enabled in an environment with no Internet access takes ~9 minutes. Most of that time is spent waiting for test_http to timeout on network:

Reviewed By: yilei

Differential Revision: D69376997

fbshipit-source-id: 4aa2b0851dc6fdfe28870ed0fa3d95805706c84e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@itamaro itamaro

Labels
tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@carljm @itamaro