Skip to content

test_sqlite3/test_dump.py Fails if SQLite Foreign Keys Enabled #123849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Derothin opened this issue Sep 8, 2024 · 1 comment
Closed

test_sqlite3/test_dump.py Fails if SQLite Foreign Keys Enabled #123849

Derothin opened this issue Sep 8, 2024 · 1 comment
Labels
tests Tests in the Lib/test dir topic-sqlite3 type-bug An unexpected behavior, bug, or error

Comments

@Derothin
Copy link

Derothin commented Sep 8, 2024 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

Just compiled 3.13.0rc2 today and ran into this issue with test_sqlite3. A commit added an intentional foreign key violation in test_dump.py, but the test doesn't consider that SQLite may have been compiled with foreign keys enabled by default. Just needs to have that turned off for the test.

CPython versions tested on:

3.13

Operating systems tested on:

Linux

Linked PRs
@Derothin Derothin added the type-bug An unexpected behavior, bug, or error label Sep 8, 2024
@Eclips4 Eclips4 added tests Tests in the Lib/test dir topic-sqlite3 labels Sep 8, 2024
felixxm added a commit to felixxm/cpython that referenced this issue Sep 9, 2024
@felixxm
pythongh-123849: Fix DumpTests.test_table_dump() crash on SQLite when…
b9f9c58 
… foreign keys are enabled by default.

Thanks Derothin for the report.

Test regression in de777e4.
@bedevere-app bedevere-app bot mentioned this issue Sep 9, 2024
Merged
erlend-aasland added a commit to felixxm/cpython that referenced this issue Oct 8, 2024
@erlend-aasland
Merge branch 'main' into pythongh-123849
7b67345
erlend-aasland pushed a commit that referenced this issue Oct 8, 2024
@felixxm
gh-123849: Fix test_sqlite3.test_table_dump when foreign keys are ena…
14b44c5 
…bled by default (#123859)
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Oct 8, 2024
@felixxm @miss-islington
pythongh-123849: Fix test_sqlite3.test_table_dump when foreign keys a…
0b7de29 
…re enabled by default (pythonGH-123859)

(cherry picked from commit 14b44c5)

Co-authored-by: Mariusz Felisiak <[email protected]>
@bedevere-app bedevere-app bot mentioned this issue Oct 8, 2024
Merged
efimov-mikhail pushed a commit to efimov-mikhail/cpython that referenced this issue Oct 9, 2024
@felixxm @efimov-mikhail
pythongh-123849: Fix test_sqlite3.test_table_dump when foreign keys a…
5f4da9b 
…re enabled by default (python#123859)
@tomasr8 tomasr8 mentioned this issue Oct 9, 2024
Closed
erlend-aasland pushed a commit that referenced this issue Oct 13, 2024
@miss-islington @felixxm
[3.13] gh-123849: Fix test_sqlite3.test_table_dump when foreign keys …
98655ce 
…are enabled by default (GH-123859) (#125163)

(cherry picked from commit 14b44c5)

Co-authored-by: Mariusz Felisiak <[email protected]>
@erlend-aasland
Copy link
Contributor

Fixed in main and the 3.13 branch. Thanks for the report, @Derothin, and thanks for the fix, @felixxm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests Tests in the Lib/test dir topic-sqlite3 type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@erlend-aasland @Eclips4 @Derothin