Skip to content

Incorrect slot check: typo in __dictoffset__ #123935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sobolevn opened this issue Sep 11, 2024 · 3 comments
Closed

Incorrect slot check: typo in __dictoffset__ #123935

sobolevn opened this issue Sep 11, 2024 · 3 comments
Assignees
@sobolevn
Labels
3.12 only security fixes 3.13 bugs and security fixes stdlib Python modules in the Lib dir topic-dataclasses type-bug An unexpected behavior, bug, or error

Comments

@sobolevn
Copy link
Member

sobolevn commented Sep 11, 2024 •
edited by bedevere-app bot
Loading

Bug report

I made a typo that made it into the final code:

cpython/Lib/dataclasses.py

Lines 1211 to 1212 in 00ffdf2

if getattr(cls, '__dictrefoffset__', -1) != 0:
slots.append('__dict__')

It should had been __dictoffset__ not __dictrefoffset__.

Fixing plan:

  • Add tests for C types with __dictoffset__, so it won't happen again :)
  • Fix the typo

Linked PRs
@sobolevn sobolevn added type-bug An unexpected behavior, bug, or error stdlib Python modules in the Lib dir topic-dataclasses labels Sep 11, 2024
@sobolevn sobolevn self-assigned this Sep 11, 2024
@picnixz
Copy link
Member

picnixz commented Sep 11, 2024

Out of curiosity... how did you find it?

@sobolevn
Copy link
Member Author

I have a telegram channel, where I post different Python-related posts. Today I posted about how slots work in dataclasses. And one of my readers found this typo :)

sobolevn added a commit to sobolevn/cpython that referenced this issue Sep 11, 2024
@sobolevn
pythongh-123935: Fix typo in _get_slots in dataclasses.py
d085d00
sobolevn added a commit to sobolevn/cpython that referenced this issue Sep 11, 2024
@sobolevn
pythongh-123935: Fix typo in _get_slots in dataclasses.py
4bf23e6
@bedevere-app bedevere-app bot mentioned this issue Sep 11, 2024
Merged
@sobolevn sobolevn changed the title Incorrect slot check: typo in __dictoffest__ Incorrect slot check: typo in __dictoffset__ Sep 11, 2024
@vstinner vstinner added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Sep 11, 2024
@picnixz picnixz added 3.12 only security fixes 3.13 bugs and security fixes and removed needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Sep 11, 2024
sobolevn added a commit that referenced this issue Sep 12, 2024
@sobolevn
gh-123935: Fix typo in _get_slots in dataclasses.py (#123941)
ac918cc
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Sep 12, 2024
@sobolevn @miss-islington
pythongh-123935: Fix typo in _get_slots in dataclasses.py (python…
883f1bd 
…GH-123941)

(cherry picked from commit ac918cc)

Co-authored-by: sobolevn <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Sep 12, 2024
@sobolevn @miss-islington
pythongh-123935: Fix typo in _get_slots in dataclasses.py (python…
bae0c1c 
…GH-123941)

(cherry picked from commit ac918cc)

Co-authored-by: sobolevn <[email protected]>
This was referenced Sep 12, 2024
Merged
Merged
sobolevn added a commit that referenced this issue Sep 12, 2024
@miss-islington @sobolevn
[3.12] gh-123935: Fix typo in _get_slots in dataclasses.py (GH-12…
9e93556 
…3941) (#123992)

gh-123935: Fix typo in `_get_slots` in `dataclasses.py` (GH-123941)
(cherry picked from commit ac918cc)

Co-authored-by: sobolevn <[email protected]>
Yhg1s pushed a commit that referenced this issue Dec 3, 2024
@miss-islington @sobolevn
[3.13] gh-123935: Fix typo in _get_slots in dataclasses.py (GH-12…
ae3f347 
…3941) (#123991)

gh-123935: Fix typo in `_get_slots` in `dataclasses.py` (GH-123941)
(cherry picked from commit ac918cc)

Co-authored-by: sobolevn <[email protected]>
@hugovk
Copy link
Member

hugovk commented Jan 7, 2025

PR merged and backported 🚀

@hugovk hugovk closed this as completed Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sobolevn sobolevn

Labels
3.12 only security fixes 3.13 bugs and security fixes stdlib Python modules in the Lib dir topic-dataclasses type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@vstinner @hugovk @sobolevn @picnixz