Skip to content

Ignore compiler warnings for entire file or directory in CI tooling #124190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nohlson opened this issue Sep 17, 2024 · 0 comments
Closed

Ignore compiler warnings for entire file or directory in CI tooling #124190

nohlson opened this issue Sep 17, 2024 · 0 comments
Labels
type-feature A feature request or enhancement

Comments

@nohlson
Copy link
Contributor

nohlson commented Sep 17, 2024 •
edited by bedevere-app bot
Loading

Feature or enhancement

Proposal:

CI warning check tooling needs to ignore entire files or directories. Currently Tools/build/.warningignore_ubuntu and Tools/build/.warningignore_macos contain file paths and a count of warnings to ignore per file. Tools/build/check_warnings.py should be able to ignore all warnings from a file or an entire directory.

For example:

Objects/longobject.c 46
Objects/memoryobject.c *
Objects/methodobject.c 1
Objects/mimalloc/ *

Has this already been discussed elsewhere?

This is a minor feature, which does not need previous discussion elsewhere

Links to previous discussion of this feature:

No response

Linked PRs
@nohlson nohlson added the type-feature A feature request or enhancement label Sep 17, 2024
@bedevere-app bedevere-app bot mentioned this issue Sep 17, 2024
Merged
hugovk pushed a commit that referenced this issue Sep 18, 2024
@nohlson @blurb-it
gh-124190: Ignore files directories check warning tooling (#124193)
81480e6 
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
@zware zware mentioned this issue Sep 18, 2024
Merged
@nohlson nohlson closed this as completed Sep 19, 2024
savannahostrowski pushed a commit to savannahostrowski/cpython that referenced this issue Sep 22, 2024
@nohlson @blurb-it @savannahostrowski
pythongh-124190: Ignore files directories check warning tooling (pyth…
69d3f21 
…on#124193)

Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nohlson