Skip to content

Correct name of zconf.in.h is zconf.h.in #127248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
smurav opened this issue Nov 25, 2024 · 2 comments
Closed

Correct name of zconf.in.h is zconf.h.in #127248

smurav opened this issue Nov 25, 2024 · 2 comments
Labels
build The build process and cross-build easy OS-windows

Comments

@smurav
Copy link
Contributor

smurav commented Nov 25, 2024 •
edited by bedevere-app bot
Loading

The file zconf.in.h should be renamed to zconf.h.in (https://github.com/python/cpython-source-deps/blob/4dc98e1909830e2bdc2a9cc2236e3c5d5037335b/zconf.h.in).

cpython/PCbuild/pythoncore.vcxproj

Line 418 in c595eae

<ClInclude Include="$(zlibDir)\zconf.in.h" />

Linked PRs
@ZeroIntensity ZeroIntensity added OS-windows build The build process and cross-build easy labels Nov 25, 2024
@ZeroIntensity
Copy link
Member

PR welcome :)

@zooba
Copy link
Member

zooba commented Nov 25, 2024

#127249 is fixing this. I'll update the PR to reference the issue.

zooba pushed a commit that referenced this issue Nov 25, 2024
@smurav
gh-127248: Fix several removed or misnamed files in pythoncore.vcxproj (
3e7ce6e 
GH-127249)
@github-actions github-actions bot mentioned this issue Dec 1, 2024
Closed
ebonnal pushed a commit to ebonnal/cpython that referenced this issue Jan 12, 2025
@smurav @ebonnal
pythongh-127248: Fix several removed or misnamed files in pythoncore.…
42cb59d 
…vcxproj (pythonGH-127249)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build The build process and cross-build easy OS-windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@smurav @zooba @ZeroIntensity