Skip to content

Emscripten: Make python.sh function as proper Python CLI #127503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hoodmane opened this issue Dec 2, 2024 · 0 comments · Fixed by #127506
Closed

Emscripten: Make python.sh function as proper Python CLI #127503

hoodmane opened this issue Dec 2, 2024 · 0 comments · Fixed by #127506
Labels
OS-emscripten type-bug An unexpected behavior, bug, or error

Comments

@hoodmane
Copy link
Contributor

hoodmane commented Dec 2, 2024 •
edited by bedevere-app bot
Loading

There are several problems with python.sh right now:

  1. It doesn't work correctly on macs with bsd coreutils
  2. It doesn't mount the native file system into the Emscripten file system, so python.sh /some/file.py will fail to find the file
  3. It doesn't set the current directory in the Emscripten file system to the same as the host working directory so python.sh file.py won't look for file.py in the current directory
  4. It doesn't inherit environment variables

@freakboy3742

Linked PRs
@hoodmane hoodmane changed the title Emscripten: Make python.sh function as a proper CLI entrypoint Emscripten: Make python.sh function as proper Python CLI Dec 2, 2024
@picnixz picnixz added the type-bug An unexpected behavior, bug, or error label Dec 2, 2024
@bedevere-app bedevere-app bot mentioned this issue Dec 2, 2024
Merged
freakboy3742 pushed a commit that referenced this issue Dec 5, 2024
@hoodmane
gh-127503: Emscripten make Python.sh function as proper Python CLI (#…
87faf0a 
…127506)

Modifies the python.sh script to work on macOS, and adapt to recent emscripten changes.
@hoodmane hoodmane reopened this Dec 5, 2024
hoodmane added a commit to hoodmane/cpython that referenced this issue Dec 5, 2024
@hoodmane
pythongh-127503: Fix realpath handling in emscripten cli
73fe44b
@bedevere-app bedevere-app bot mentioned this issue Dec 5, 2024
Merged
hoodmane added a commit to hoodmane/cpython that referenced this issue Dec 5, 2024
@hoodmane
pythongh-127503 Don't propagate native PATH to Emscripten Python
a7afdf9 
This makes `shutil.which()` pick up native executables which is inconvenient.
@bedevere-app bedevere-app bot mentioned this issue Dec 5, 2024
Merged
freakboy3742 pushed a commit that referenced this issue Dec 9, 2024
@hoodmane
gh-127503 Don't propagate native PATH to Emscripten Python (#127633)
5876063 
Modifies the handling of PATH to ensure that native executables aren't picked
up when running under node.
freakboy3742 pushed a commit that referenced this issue Dec 9, 2024
@hoodmane
gh-127503: Fix realpath handling in emscripten cli (#127632)
d8d12b3 
Corrects the handling of realpath on Linux.
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this issue Jan 8, 2025
@hoodmane @srinivasreddy
pythongh-127503: Emscripten make Python.sh function as proper Python …
6c4b1ca 
…CLI (python#127506)

Modifies the python.sh script to work on macOS, and adapt to recent emscripten changes.
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this issue Jan 8, 2025
@hoodmane @srinivasreddy
pythongh-127503 Don't propagate native PATH to Emscripten Python (pyt…
3c4647f 
…hon#127633)

Modifies the handling of PATH to ensure that native executables aren't picked
up when running under node.
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this issue Jan 8, 2025
@hoodmane @srinivasreddy
pythongh-127503: Fix realpath handling in emscripten cli (python#127632)
e0253e4 
Corrects the handling of realpath on Linux.
hoodmane added a commit to hoodmane/cpython that referenced this issue Mar 12, 2025
@hoodmane
pythongh-127503: Improve tracebacks on Emscripten when there is a trap
490c765 
This PR solves two problems:
1. No Python traceback shown on segfault/trap
2. The JavaScript source line is shown

The JavaScript source line is super long and completely unenlightening,
whereas the Python traceback is very helpful.
hoodmane added a commit to hoodmane/cpython that referenced this issue Mar 12, 2025
@hoodmane
pythongh-127503: Improve tracebacks on Emscripten when there is a trap
f173d1f 
This PR solves two problems:
1. No Python traceback shown on segfault/trap
2. The JavaScript source line is shown

The JavaScript source line is super long and completely unenlightening,
whereas the Python traceback is very helpful.
@bedevere-app bedevere-app bot mentioned this issue Mar 12, 2025
Merged
hoodmane added a commit to hoodmane/cpython that referenced this issue Mar 12, 2025
@hoodmane
pythongh-127503: Improve tracebacks on Emscripten when there is a trap
19a197c 
This PR solves two problems:
1. No Python traceback shown on segfault/trap
2. The JavaScript source line is shown

The JavaScript source line is super long and completely unenlightening,
whereas the Python traceback is very helpful.
freakboy3742 pushed a commit that referenced this issue Mar 13, 2025
@hoodmane
gh-127503: Improve tracebacks on Emscripten when there is a trap (#13…
db1e582 
…1158)

Modifies the behavior of the interpreter on crash under Emscripten:
1. No Python traceback shown on segfault/trap
2. The JavaScript source line is shown

The JavaScript source line is super long and completely unenlightening,
whereas the Python traceback is very helpful.
plashchynski pushed a commit to plashchynski/cpython that referenced this issue Mar 17, 2025
@hoodmane @plashchynski
pythongh-127503: Improve tracebacks on Emscripten when there is a trap (
23c17ba 
python#131158)

Modifies the behavior of the interpreter on crash under Emscripten:
1. No Python traceback shown on segfault/trap
2. The JavaScript source line is shown

The JavaScript source line is super long and completely unenlightening,
whereas the Python traceback is very helpful.
seehwan pushed a commit to seehwan/cpython that referenced this issue Apr 16, 2025
@hoodmane @seehwan80
pythongh-127503: Improve tracebacks on Emscripten when there is a trap (
ef284d7 
python#131158)

Modifies the behavior of the interpreter on crash under Emscripten:
1. No Python traceback shown on segfault/trap
2. The JavaScript source line is shown

The JavaScript source line is super long and completely unenlightening,
whereas the Python traceback is very helpful.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
OS-emscripten type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-127503: Emscripten make Python.sh function as proper Python CLI hoodmane/cpython
2 participants
@hoodmane @picnixz