Skip to content

Improve error-branches of hashlib #127667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
picnixz opened this issue Dec 6, 2024 · 0 comments
Closed

Improve error-branches of hashlib #127667

picnixz opened this issue Dec 6, 2024 · 0 comments
Assignees
@picnixz
Labels
3.12 only security fixes 3.13 bugs and security fixes 3.14 bugs and security fixes extension-modules C modules in the Modules dir type-bug An unexpected behavior, bug, or error

Comments

@picnixz
Copy link
Member

picnixz commented Dec 6, 2024 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

While reading the hashlib code, I found some issues in the error branches where the EVP_MD_ctx is not freed upon failure or when we call py_digest_name with a NULL EVP_MD *.

@gpshead Should I consider this as a security issue? (some places might be a security issue since we are leaking some EVP_MD context objects but others are just leaking un-initialized contexts).

CPython versions tested on:

CPython main branch

Operating systems tested on:

No response

Linked PRs
@picnixz picnixz added type-bug An unexpected behavior, bug, or error extension-modules C modules in the Modules dir 3.12 only security fixes 3.13 bugs and security fixes 3.14 bugs and security fixes labels Dec 6, 2024
@picnixz picnixz self-assigned this Dec 6, 2024
@bedevere-app bedevere-app bot mentioned this issue Dec 6, 2024
Merged
@picnixz picnixz changed the title Memory leaks in error-branches of hashlib Improve error-branches of hashlib Jan 5, 2025
picnixz added a commit that referenced this issue Mar 3, 2025
@picnixz
gh-127667: fix memory leaks in hashlib (#127668)
0978465 
- Correctly handle `NULL` values returned by `EVP_MD_CTX_md`.
- Correctly free resources in error branches.
- Consistently suppress `_setException()` return value when needed.
- Collapse `_setException() + return NULL` into a single statement.
picnixz added a commit to picnixz/cpython that referenced this issue Mar 3, 2025
@picnixz
pythongh-127667: fix memory leaks in hashlib (python#127668)
246c2e2 
- Correctly handle `NULL` values returned by `EVP_MD_CTX_md`.
- Correctly free resources in error branches.
- Consistently suppress `_setException()` return value when needed.
- Collapse `_setException() + return NULL` into a single statement.
@bedevere-app bedevere-app bot mentioned this issue Mar 3, 2025
Merged
picnixz added a commit to picnixz/cpython that referenced this issue Mar 3, 2025
@picnixz
pythongh-127667: fix memory leaks in hashlib (python#127668)
107fda4 
- Correctly handle `NULL` values returned by `EVP_MD_CTX_md`.
- Correctly free resources in error branches.
- Consistently suppress `_setException()` return value when needed.
- Collapse `_setException() + return NULL` into a single statement.
@bedevere-app bedevere-app bot mentioned this issue Mar 3, 2025
Merged
picnixz added a commit that referenced this issue Mar 3, 2025
@picnixz
[3.12] gh-127667: fix memory leaks in hashlib (GH-127668) (#130783)
d25da89 
gh-127667: fix memory leaks in `hashlib` (GH-127668)

- Correctly handle `NULL` values returned by `EVP_MD_CTX_md`.
- Correctly free resources in error branches.
- Consistently suppress `_setException()` return value when needed.
- Collapse `_setException() + return NULL` into a single statement.

(cherry-picked from commit 0978465)
picnixz added a commit that referenced this issue Mar 3, 2025
@picnixz
[3.13] gh-127667: fix memory leaks in hashlib (GH-127668) (#130784)
9643ce9 
gh-127667: fix memory leaks in `hashlib` (GH-127668)

- Correctly handle `NULL` values returned by `EVP_MD_CTX_md`.
- Correctly free resources in error branches.
- Consistently suppress `_setException()` return value when needed.
- Collapse `_setException() + return NULL` into a single statement.

(cherry-picked from commit 0978465)
@bedevere-app bedevere-app bot mentioned this issue Mar 12, 2025
Merged
picnixz added a commit that referenced this issue Mar 17, 2025
@picnixz
gh-127667: refactor and improve _hashopenssl.c error branches (#131145
ac50ece 
)

Refactor `_setException()` into different helpers that can be used separately:

- set_ssl_exception_from_errcode(): set an exception from an explicit SSL error code.
- raise_ssl_error(): set an exception from the last SSL error code or use a user-defined message.
- notify_ssl_error_occurred(): same as raise_ssl_error() but with a generic default message.
picnixz added a commit to picnixz/cpython that referenced this issue Mar 17, 2025
@picnixz
pythongh-127667: refactor and improve _hashopenssl.c error branches (…
26b29ca 
…python#131145)

Refactor `_setException()` into different helpers that can be used separately:

- set_ssl_exception_from_errcode(): set an exception from an explicit SSL error code.
- raise_ssl_error(): set an exception from the last SSL error code or use a user-defined message.
- notify_ssl_error_occurred(): same as raise_ssl_error() but with a generic default message.
@bedevere-app bedevere-app bot mentioned this issue Mar 17, 2025
Merged
picnixz added a commit to picnixz/cpython that referenced this issue Mar 17, 2025
@picnixz
pythongh-127667: refactor and improve _hashopenssl.c error branches (…
992c10b 
…python#131145)

Refactor `_setException()` into different helpers that can be used separately:

- set_ssl_exception_from_errcode(): set an exception from an explicit SSL error code.
- raise_ssl_error(): set an exception from the last SSL error code or use a user-defined message.
- notify_ssl_error_occurred(): same as raise_ssl_error() but with a generic default message.

# Conflicts:
#	Modules/_hashopenssl.c
@bedevere-app bedevere-app bot mentioned this issue Mar 17, 2025
Merged
plashchynski pushed a commit to plashchynski/cpython that referenced this issue Mar 17, 2025
@picnixz @plashchynski
pythongh-127667: refactor and improve _hashopenssl.c error branches (…
d1c51c2 
…python#131145)

Refactor `_setException()` into different helpers that can be used separately:

- set_ssl_exception_from_errcode(): set an exception from an explicit SSL error code.
- raise_ssl_error(): set an exception from the last SSL error code or use a user-defined message.
- notify_ssl_error_occurred(): same as raise_ssl_error() but with a generic default message.
picnixz added a commit that referenced this issue Mar 18, 2025
@picnixz
[3.12] gh-127667: refactor and improve _hashopenssl.c error branches (
304ef84 
#131145) (#131348)

gh-127667: refactor and improve `_hashopenssl.c` error branches (#131145)

Refactor `_setException()` into different helpers that can be used separately:

- set_ssl_exception_from_errcode(): set an exception from an explicit SSL error code.
- raise_ssl_error(): set an exception from the last SSL error code or use a user-defined message.
- notify_ssl_error_occurred(): same as raise_ssl_error() but with a generic default message.

(cherry-picked from commit ac50ece).
picnixz added a commit that referenced this issue Mar 18, 2025
@picnixz
[3.13] gh-127667: refactor and improve _hashopenssl.c error branches (
170abd2 
#131145) (#131347)

gh-127667: refactor and improve `_hashopenssl.c` error branches (#131145)

Refactor `_setException()` into different helpers that can be used separately:

- set_ssl_exception_from_errcode(): set an exception from an explicit SSL error code.
- raise_ssl_error(): set an exception from the last SSL error code or use a user-defined message.
- notify_ssl_error_occurred(): same as raise_ssl_error() but with a generic default message.

(cherry-picked from commit ac50ece).
@picnixz picnixz closed this as completed Mar 18, 2025
@picnixz picnixz reopened this Mar 18, 2025
@picnixz picnixz closed this as completed Mar 18, 2025
seehwan pushed a commit to seehwan/cpython that referenced this issue Apr 16, 2025
@picnixz @seehwan80
pythongh-127667: fix memory leaks in hashlib (python#127668)
f133cf0 
- Correctly handle `NULL` values returned by `EVP_MD_CTX_md`.
- Correctly free resources in error branches.
- Consistently suppress `_setException()` return value when needed.
- Collapse `_setException() + return NULL` into a single statement.
seehwan pushed a commit to seehwan/cpython that referenced this issue Apr 16, 2025
@picnixz @seehwan80
pythongh-127667: refactor and improve _hashopenssl.c error branches (…
f5fc252 
…python#131145)

Refactor `_setException()` into different helpers that can be used separately:

- set_ssl_exception_from_errcode(): set an exception from an explicit SSL error code.
- raise_ssl_error(): set an exception from the last SSL error code or use a user-defined message.
- notify_ssl_error_occurred(): same as raise_ssl_error() but with a generic default message.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@picnixz picnixz

Labels
3.12 only security fixes 3.13 bugs and security fixes 3.14 bugs and security fixes extension-modules C modules in the Modules dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@picnixz