-
-
Notifications
You must be signed in to change notification settings - Fork 32k
Improving signature of urllib.request.HTTPPasswordMgrWithPriorAuth.__init__
#127734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Comments
orsenthil
pushed a commit
that referenced
this issue
Dec 8, 2024
…iorAuth.__init__` (#127735) improve signature of urllib.request.HTTPPasswordMgrWithPriorAuth.__init__
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this issue
Dec 8, 2024
…WithPriorAuth.__init__` (pythonGH-127735) improve signature of urllib.request.HTTPPasswordMgrWithPriorAuth.__init__ (cherry picked from commit a03efb5) Co-authored-by: Stephen Morton <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this issue
Dec 8, 2024
…WithPriorAuth.__init__` (pythonGH-127735) improve signature of urllib.request.HTTPPasswordMgrWithPriorAuth.__init__ (cherry picked from commit a03efb5) Co-authored-by: Stephen Morton <[email protected]>
orsenthil
pushed a commit
that referenced
this issue
Dec 8, 2024
…rWithPriorAuth.__init__` (GH-127735) (#127744) gh-127734: improve signature of `urllib.request.HTTPPasswordMgrWithPriorAuth.__init__` (GH-127735) improve signature of urllib.request.HTTPPasswordMgrWithPriorAuth.__init__ (cherry picked from commit a03efb5) Co-authored-by: Stephen Morton <[email protected]>
orsenthil
pushed a commit
that referenced
this issue
Dec 8, 2024
…rWithPriorAuth.__init__` (GH-127735) (#127745) gh-127734: improve signature of `urllib.request.HTTPPasswordMgrWithPriorAuth.__init__` (GH-127735) improve signature of urllib.request.HTTPPasswordMgrWithPriorAuth.__init__ (cherry picked from commit a03efb5) Co-authored-by: Stephen Morton <[email protected]>
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this issue
Jan 8, 2025
…WithPriorAuth.__init__` (python#127735) improve signature of urllib.request.HTTPPasswordMgrWithPriorAuth.__init__
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature or enhancement
Proposal:
urllib.request.HTTPPasswordMgrWithPriorAuth.__init__
(link) has(self, *args, **kwargs)
, but the args are just passed through to super, and the superclass forHTTPPasswordMgrWithPriorAuth
takes no arguments. The passthrough doesn't serve a purpose and it muddies introspection of the method. I'd like to updateurllib.request.HTTPPasswordMgrWithPriorAuth.__init__
to have no arguments, so that signature introspection is more accurate. Currently, typeshed needs to haveurllib.request.HTTPPasswordMgrWithPriorAuth.__init__
on its allowlist for stubtest errors as a result of the poor introspection.Has this already been discussed elsewhere?
This is a minor feature, which does not need previous discussion elsewhere
Links to previous discussion of this feature:
No response
Linked PRs
urllib.request.HTTPPasswordMgrWithPriorAuth.__init__
#127735urllib.request.HTTPPasswordMgrWithPriorAuth.__init__
(GH-127735) #127744urllib.request.HTTPPasswordMgrWithPriorAuth.__init__
(GH-127735) #127745The text was updated successfully, but these errors were encountered: