-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
Increase test coverage of gettext
#130655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I'll open a PR for find sometime tomorrow :-) |
…thonGH-130656) (cherry picked from commit 24c52cb) Co-authored-by: Tomas R. <[email protected]>
…thonGH-130656) (cherry picked from commit 24c52cb) Co-authored-by: Tomas R. <[email protected]>
…H-130656) (GH-130672) (cherry picked from commit 24c52cb) Co-authored-by: Tomas R <[email protected]>
…H-130656) (GH-130671) (cherry picked from commit 24c52cb) Co-authored-by: Tomas R <[email protected]>
Co-authored-by: Tomas R. <[email protected]>
Thanks for the tests! |
Up to you, IIRC there are some code paths related to parsing MO files which are also not covered. I was going to send a PR for that at some point, but that can also be done in a separate issue if you prefer to close this one. |
Co-authored-by: Tomas R. <[email protected]>
gettext.find
and gettext._expand_lang
gettext
…ed by `gettext` (pythonGH-131909) (cherry picked from commit 16a6270) Co-authored-by: Tomas R. <[email protected]>
…ed by `gettext` (pythonGH-131909) (cherry picked from commit 16a6270) Co-authored-by: Tomas R. <[email protected]>
…honGH-131911) (cherry picked from commit a126cef) Co-authored-by: Tomas R. <[email protected]>
…honGH-131911) (cherry picked from commit a126cef) Co-authored-by: Tomas R. <[email protected]>
(cherry picked from commit 3118693) Co-authored-by: Stan Ulbrych <[email protected]> Co-authored-by: Tomas R. <[email protected]>
(cherry picked from commit 3118693) Co-authored-by: Stan Ulbrych <[email protected]> Co-authored-by: Tomas R. <[email protected]>
gh-130655: Add tests for `gettext.find()` (GH-130691) (cherry picked from commit 3118693) Co-authored-by: Stan Ulbrych <[email protected]> Co-authored-by: Tomas R. <[email protected]>
gh-130655: Add tests for `gettext.find()` (GH-130691) (cherry picked from commit 3118693) Co-authored-by: Stan Ulbrych <[email protected]> Co-authored-by: Tomas R. <[email protected]>
Coverage is now at 85%! |
The test file should be split into a data file and a test file IMO, any thoughts on this? See POC #132442 |
Soon to be 86% 😆 I have a test for big-endian MO files lying around somewhere. |
Co-authored-by: Tomas R. <[email protected]>
…ed by `gettext` (python#131909)
The test coverage for these functions is low as there are no dedicated tests for them. I propose we add tests for these functions.
This will come in handy if/when we decide to fix #64243.
Linked PRs
gettext._expand_lang
#130656gettext.find()
#130691.mo
files parsed bygettext
(GH-131909) #132077.mo
files parsed bygettext
(GH-131909) #132078.mo
files ingettext
(GH-131911) #132079.mo
files ingettext
(GH-131911) #132080gettext.find()
(GH-130691) #132083gettext.find()
(GH-130691) #132084test_gettext
data to a separate file #132442gettext
#132469The text was updated successfully, but these errors were encountered: